Skip to content

Commit f8d3309

Browse files
authored
fix: validate chain proposal length against chain exchange max length (#942)
Otherwise the only valid value was chain exchange max length equal to proposal chain length Signed-off-by: Jakub Sztandera <[email protected]>
1 parent 270fa90 commit f8d3309

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

manifest/manifest.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -423,8 +423,8 @@ func (m *Manifest) Validate() error {
423423
if err := m.PartialMessageManager.Validate(); err != nil {
424424
return fmt.Errorf("invalid manifest: invalid partial message manager config: %w", err)
425425
}
426-
if m.ChainExchange.MaxChainLength > m.Gpbft.ChainProposedLength {
427-
return fmt.Errorf("invalid manifest: chain exchange max chain length %d exceeds gpbft proposed chain length %d", m.ChainExchange.MaxChainLength, m.Gpbft.ChainProposedLength)
426+
if m.Gpbft.ChainProposedLength > m.ChainExchange.MaxChainLength {
427+
return fmt.Errorf("invalid manifest: chain proposal length %d is greater than chain exchange max chain length %d", m.Gpbft.ChainProposedLength, m.ChainExchange.MaxChainLength)
428428
}
429429
if m.ChainExchange.MaxInstanceLookahead > m.CommitteeLookback {
430430
return fmt.Errorf("invalid manifest: chain exchange max instance lookahead %d exceeds committee lookback %d", m.ChainExchange.MaxInstanceLookahead, m.CommitteeLookback)

0 commit comments

Comments
 (0)