Build pyvrs oss for Windows (#41)

Summary:
Pull Request resolved: #41

Build pyvrs oss for Windows

Reviewed By: kiminoue7

Differential Revision: D56352466

fbshipit-source-id: 3f5a41c56fa7dd386ab9d70488f6b2013a738fdb

Author: Peter Wang

cmake/FindLz4.cmake

@@ -20,7 +20,7 @@
 # Lz4_FOUND - True if Lz4 found.
 
 find_path(Lz4_INCLUDE_DIRS NAMES lz4.h)
-find_library(Lz4_LIBRARIES NAMES lz4)
+find_library(Lz4_LIBRARIES NAMES lz4 liblz4)
 mark_as_advanced(Lz4_LIBRARIES Lz4_INCLUDE_DIRS)
 
 include(FindPackageHandleStandardArgs)

csrc/utils/PyUtils.cpp

@@ -16,6 +16,8 @@
 
 #include "PyUtils.h"
 
+#include <algorithm>
+
 #define DEFAULT_LOG_CHANNEL "PyUtils"
 #include <logging/Log.h>
 
@@ -39,13 +41,13 @@ string typeName(const DataPiece* piece, const char* suffix) {
 
 string lowercaseTypeName(Record::Type type) {
   string typeName = toString(type);
-  transform(typeName.begin(), typeName.end(), typeName.begin(), ::tolower);
+  std::transform(typeName.begin(), typeName.end(), typeName.begin(), ::tolower);
   return typeName;
 }
 
 string toupper(const string& s) {
   string t{s};
-  transform(t.begin(), t.end(), t.begin(), ::toupper);
+  std::transform(t.begin(), t.end(), t.begin(), ::toupper);
   return t;
 }
 

pixi.toml

@@ -0,0 +1,32 @@
+[project]
+name = "pyvrs"
+version = "0.1.0"
+description = "pyvrs is a Python interface for C++ library VRS using pybind11."
+channels = ["conda-forge"]
+platforms = ["win-64"]
+
+[tasks]
+
+install_pyvrs = "python -m pip install -e ."
+clean = "rm -rf ./build ./wheels vrs.egg-info/"
+
+[build-dependencies]
+cmake = "3.28.3"
+cxx-compiler = "1.6.0.*"
+ninja = "1.11.1"
+
+[dependencies]
+gtest = "1.14.0"
+
+boost = "1.84.0"
+fmt = "10.1.1"
+libjpeg-turbo = "2.1.4.*"
+libpng = "1.6.39.*"
+lz4 = "4.3.2.*"
+portaudio = "19.6.0.*"
+xxhash = "0.8.2"
+zlib = "1.2.13.*"
+
+# Install Python dependencies
+python = "3.11.*"
+pip = "*"

setup.py

@@ -15,6 +15,7 @@
 
 import os
 import re
+import shutil
 import subprocess
 import sys
 from pathlib import Path
@@ -79,16 +80,18 @@ def build_extension(self, ext):
             f"-DCMAKE_BUILD_TYPE={cfg}",
             f"-DCMAKE_LIBRARY_OUTPUT_DIRECTORY={extdir}",
             f"-DPYTHON_EXECUTABLE={sys.executable}",
-            "-GCodeBlocks",
         ]
         build_args = ["--target", os.path.basename(ext.name)]
 
         if "CMAKE_ARGS" in os.environ:
             cmake_args += [item for item in os.environ["CMAKE_ARGS"].split(" ") if item]
 
-        # Default to Ninja
-        if "CMAKE_GENERATOR" not in os.environ:
-            cmake_args += ["-GNinja"]
+        if sys.platform.startswith("win"):
+            build_args += ["--config", "Release"]
+        else:
+            # Default to Ninja
+            if "CMAKE_GENERATOR" not in os.environ:
+                cmake_args += ["-GNinja"]
 
         if sys.platform.startswith("darwin"):
             # Cross-compile support for macOS - respect ARCHFLAGS if set
@@ -105,6 +108,12 @@ def build_extension(self, ext):
             ["cmake", "--build", "."] + build_args, cwd=self.build_temp
         )
 
+        if sys.platform.startswith("win"):
+            [
+                shutil.copy(os.path.join(f"{extdir}/Release/", f), extdir)
+                for f in os.listdir(f"{extdir}/Release/")
+            ]
+
 
 def main():
     with open(os.path.join(ROOT_DIR, "README.md"), encoding="utf-8") as f: