Skip to content

Commit e669006

Browse files
kvtsoyfacebook-github-bot
authored andcommitted
Fix OSS build
Summary: X-link: facebookincubator/zstrong#1007 X-link: facebook/proxygen#518 facebook/proxygen#510 git patches on Windows OSS proxygen builds been failing for a while because of new lines Windows vs Unix. I re-generated the patches on Windows and that seems to fix it, and it also works for linux builds so seems fine. Reviewed By: afrind, bigfootjon Differential Revision: D63148510 fbshipit-source-id: 0ee605896820784335c1acd2a3e22b3bdf8394f1
1 parent 6151099 commit e669006

File tree

2 files changed

+35
-34
lines changed

2 files changed

+35
-34
lines changed

build/fbcode_builder/patches/boost_comparator_operator_fix.patch

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,4 @@ diff --git a/boost/serialization/strong_typedef.hpp b/boost/serialization/strong
88
+ bool operator==(const T& lhs) const {return t == lhs;} \
99
bool operator<(const D& rhs) const {return t < rhs.t;} \
1010
};
11-
11+
Lines changed: 34 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,34 @@
1-
diff -Naur ../zlib-1.3.1/CMakeLists.txt ./CMakeLists.txt
2-
--- ../zlib-1.3.1/CMakeLists.txt 2024-01-22 10:32:37.000000000 -0800
3-
+++ ./CMakeLists.txt 2024-01-23 13:14:09.870289968 -0800
4-
@@ -149,10 +149,8 @@
5-
set(ZLIB_DLL_SRCS ${CMAKE_CURRENT_BINARY_DIR}/zlib1rc.obj)
6-
endif(MINGW)
7-
8-
-add_library(zlib SHARED ${ZLIB_SRCS} ${ZLIB_DLL_SRCS} ${ZLIB_PUBLIC_HDRS} ${ZLIB_PRIVATE_HDRS})
9-
+add_library(zlib ${ZLIB_SRCS} ${ZLIB_DLL_SRCS} ${ZLIB_PUBLIC_HDRS} ${ZLIB_PRIVATE_HDRS})
10-
target_include_directories(zlib PUBLIC ${CMAKE_CURRENT_BINARY_DIR} ${CMAKE_CURRENT_SOURCE_DIR})
11-
-add_library(zlibstatic STATIC ${ZLIB_SRCS} ${ZLIB_PUBLIC_HDRS} ${ZLIB_PRIVATE_HDRS})
12-
-target_include_directories(zlibstatic PUBLIC ${CMAKE_CURRENT_BINARY_DIR} ${CMAKE_CURRENT_SOURCE_DIR})
13-
set_target_properties(zlib PROPERTIES DEFINE_SYMBOL ZLIB_DLL)
14-
set_target_properties(zlib PROPERTIES SOVERSION 1)
15-
16-
@@ -169,7 +167,7 @@
17-
18-
if(UNIX)
19-
# On unix-like platforms the library is almost always called libz
20-
- set_target_properties(zlib zlibstatic PROPERTIES OUTPUT_NAME z)
21-
+ set_target_properties(zlib PROPERTIES OUTPUT_NAME z)
22-
if(NOT APPLE AND NOT(CMAKE_SYSTEM_NAME STREQUAL AIX))
23-
set_target_properties(zlib PROPERTIES LINK_FLAGS "-Wl,--version-script,\"${CMAKE_CURRENT_SOURCE_DIR}/zlib.map\"")
24-
endif()
25-
@@ -179,7 +177,7 @@
26-
endif()
27-
28-
if(NOT SKIP_INSTALL_LIBRARIES AND NOT SKIP_INSTALL_ALL )
29-
- install(TARGETS zlib zlibstatic
30-
+ install(TARGETS zlib
31-
RUNTIME DESTINATION "${INSTALL_BIN_DIR}"
32-
ARCHIVE DESTINATION "${INSTALL_LIB_DIR}"
33-
LIBRARY DESTINATION "${INSTALL_LIB_DIR}" )
1+
diff -Naur ../zlib-1.3.1/CMakeLists.txt ./CMakeLists.txt
2+
--- ../zlib-1.3.1/CMakeLists.txt 2024-01-22 10:32:37.000000000 -0800
3+
+++ ./CMakeLists.txt 2024-01-23 13:14:09.870289968 -0800
4+
@@ -149,10 +149,8 @@
5+
set(ZLIB_DLL_SRCS ${CMAKE_CURRENT_BINARY_DIR}/zlib1rc.obj)
6+
endif(MINGW)
7+
8+
-add_library(zlib SHARED ${ZLIB_SRCS} ${ZLIB_DLL_SRCS} ${ZLIB_PUBLIC_HDRS} ${ZLIB_PRIVATE_HDRS})
9+
+add_library(zlib ${ZLIB_SRCS} ${ZLIB_DLL_SRCS} ${ZLIB_PUBLIC_HDRS} ${ZLIB_PRIVATE_HDRS})
10+
target_include_directories(zlib PUBLIC ${CMAKE_CURRENT_BINARY_DIR} ${CMAKE_CURRENT_SOURCE_DIR})
11+
-add_library(zlibstatic STATIC ${ZLIB_SRCS} ${ZLIB_PUBLIC_HDRS} ${ZLIB_PRIVATE_HDRS})
12+
-target_include_directories(zlibstatic PUBLIC ${CMAKE_CURRENT_BINARY_DIR} ${CMAKE_CURRENT_SOURCE_DIR})
13+
set_target_properties(zlib PROPERTIES DEFINE_SYMBOL ZLIB_DLL)
14+
set_target_properties(zlib PROPERTIES SOVERSION 1)
15+
16+
@@ -169,7 +167,7 @@
17+
18+
if(UNIX)
19+
# On unix-like platforms the library is almost always called libz
20+
- set_target_properties(zlib zlibstatic PROPERTIES OUTPUT_NAME z)
21+
+ set_target_properties(zlib PROPERTIES OUTPUT_NAME z)
22+
if(NOT APPLE AND NOT(CMAKE_SYSTEM_NAME STREQUAL AIX))
23+
set_target_properties(zlib PROPERTIES LINK_FLAGS "-Wl,--version-script,\"${CMAKE_CURRENT_SOURCE_DIR}/zlib.map\"")
24+
endif()
25+
@@ -179,7 +177,7 @@
26+
endif()
27+
28+
if(NOT SKIP_INSTALL_LIBRARIES AND NOT SKIP_INSTALL_ALL )
29+
- install(TARGETS zlib zlibstatic
30+
+ install(TARGETS zlib
31+
RUNTIME DESTINATION "${INSTALL_BIN_DIR}"
32+
ARCHIVE DESTINATION "${INSTALL_LIB_DIR}"
33+
LIBRARY DESTINATION "${INSTALL_LIB_DIR}" )
34+

0 commit comments

Comments
 (0)