Remove exceptions from ConnectionId

Summary: This primarily involved making the constructors private and changing the callers of the factory functions. The crashing factory is only expected to be used by tests.

Reviewed By: kvtsoy

Differential Revision: D74347638

fbshipit-source-id: 4c0dd7fabaa233c8a3460c359462a22642d26f5b

Author: Matt Joras

proxygen/lib/http/session/HQSession.h

@@ -239,10 +239,10 @@ class HQSession
     os << "proto=" << alpn_;
     auto clientCid = (sock_ && sock_->getClientConnectionId())
                          ? *sock_->getClientConnectionId()
-                         : quic::ConnectionId({0, 0, 0, 0});
+                         : quic::ConnectionId::createZeroLength();
     auto serverCid = (sock_ && sock_->getServerConnectionId())
                          ? *sock_->getServerConnectionId()
-                         : quic::ConnectionId({0, 0, 0, 0});
+                         : quic::ConnectionId::createZeroLength();
     if (direction_ == TransportDirection::DOWNSTREAM) {
       os << ", UA=" << userAgent_ << ", client CID=" << clientCid
          << ", server CID=" << serverCid << ", downstream=" << getPeerAddress()

proxygen/lib/http/session/test/MockQuicSocketDriver.h

@@ -166,12 +166,12 @@ class MockQuicSocketDriver : public folly::EventBase::LoopCallback {
         .WillRepeatedly(testing::Return(bufferAvailable_));
 
     EXPECT_CALL(*sock_, getClientConnectionId())
-        .WillRepeatedly(
-            testing::Return(quic::ConnectionId({0x11, 0x11, 0x11, 0x11})));
+        .WillRepeatedly(testing::Return(
+            quic::ConnectionId::createAndMaybeCrash({0x11, 0x11, 0x11, 0x11})));
 
     EXPECT_CALL(*sock_, getServerConnectionId())
-        .WillRepeatedly(
-            testing::Return(quic::ConnectionId({0x11, 0x11, 0x11, 0x11})));
+        .WillRepeatedly(testing::Return(
+            quic::ConnectionId::createAndMaybeCrash({0x11, 0x11, 0x11, 0x11})));
 
     EXPECT_CALL(*sock_, getAppProtocol())
         .WillRepeatedly(testing::Return(alpn_));

proxygen/lib/transport/test/H3DatagramAsyncSocketTest.cpp

@@ -60,7 +60,7 @@ void H3DatagramAsyncSocketTest::SetUp() {
   EXPECT_CALL(*socketDriver_->getSocket(), getTransportInfo())
       .WillRepeatedly(testing::Return(transportInfo));
   EXPECT_CALL(*socketDriver_->getSocket(), getClientChosenDestConnectionId())
-      .WillRepeatedly(Return(ConnectionId::createRandom(2)));
+      .WillRepeatedly(Return(ConnectionId::createRandom(2).value()));
 }
 
 void H3DatagramAsyncSocketTest::TearDown() {