Skip to content

Commit b0a9535

Browse files
ahornbyfacebook-github-bot
authored andcommitted
fix windows build with --free-up-disk
Summary: getdeps can generate a windows wrapper script that can be used to run build artifacts from build directory. In github actions for large projects we set a getdeps option delete the build dir as soon as we've successfully installed artefacts to save disk space. This option was enabled for windows in D56165825. Turns out that didn't work, this diff adds the missing conditional so that it should. Reviewed By: vitaut Differential Revision: D56930778 fbshipit-source-id: 0cb9ac94ef9b39f4e33af8fb91098dc0d833731b
1 parent 3e3f7b0 commit b0a9535

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

build/fbcode_builder/getdeps/builder.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -158,12 +158,11 @@ def build(self, install_dirs, reconfigure: bool) -> None:
158158
os.remove(self.build_dir)
159159
else:
160160
shutil.rmtree(self.build_dir)
161-
162-
# On Windows, emit a wrapper script that can be used to run build artifacts
163-
# directly from the build directory, without installing them. On Windows $PATH
164-
# needs to be updated to include all of the directories containing the runtime
165-
# library dependencies in order to run the binaries.
166-
if self.build_opts.is_windows():
161+
elif self.build_opts.is_windows():
162+
# On Windows, emit a wrapper script that can be used to run build artifacts
163+
# directly from the build directory, without installing them. On Windows $PATH
164+
# needs to be updated to include all of the directories containing the runtime
165+
# library dependencies in order to run the binaries.
167166
script_path = self.get_dev_run_script_path()
168167
dep_munger = create_dyn_dep_munger(self.build_opts, install_dirs)
169168
dep_dirs = self.get_dev_run_extra_path_dirs(install_dirs, dep_munger)

0 commit comments

Comments
 (0)