Short circuit blacklist check.

Summary:
`count` *always* compares both strings even if the first one is already a match. It's possible to use `std::ranges::find` instead of count
but it's more verbose and unnecessary for such a simple case

Reviewed By: dmm-fb

Differential Revision: D75712432

fbshipit-source-id: 9eae3d9de9ae1c1f4ea8b27b26a22412fb9cfa6a

Author: ttsugriy

fb303/ServiceData.cpp

@@ -643,11 +643,7 @@ ServiceData::SetOptionResult ServiceData::setOptionWithResult(
 
   // By default allow modifying glog verbosity (options 'v' or 'vmodule')
   auto useOptionsAsFlags = useOptionsAsFlags_.load(std::memory_order_relaxed);
-  static constexpr StringPiece blacklistedOptions[] = {
-      StringPiece{"logmailer"}, StringPiece{"whitelist_flags"}};
-  if (std::count(
-          std::begin(blacklistedOptions), std::end(blacklistedOptions), key) >
-      0) {
+  if (key == "logmailer" || key == "whitelist_flags") {
     return SetOptionResult::CmdlineBlacklisted;
   }