Skip to content

Commit a48cfd8

Browse files
author
Elio Esteves Duarte
committed
Remove whitespace
1 parent 09b4460 commit a48cfd8

17 files changed

+19
-32
lines changed

src/main/java/com/hackerrank/github/core/entities/Actor.java

+10-10
Original file line numberDiff line numberDiff line change
@@ -30,16 +30,6 @@ public class Actor {
3030
private LocalDateTime latestEvent;
3131
private List<Event> events = new ArrayList<>();
3232

33-
public UpdateValidation validateUpdate(Actor other) {
34-
if (login.equals(other.getLogin())) {
35-
return UpdateValidation.success();
36-
} else {
37-
String errorMessage = String.format("Update of the Actor with ID '%d' failed because only field 'avatar'" +
38-
" can be change. Tried to change the field 'login'", other.getId().getNumber());
39-
return UpdateValidation.error(errorMessage);
40-
}
41-
}
42-
4333
public void calculateStreak() {
4434
int maxStreak = 0;
4535
int currentStreak = 0;
@@ -62,6 +52,16 @@ public void calculateStreak() {
6252
latestEvent = events.get(0).getCreatedAt();
6353
}
6454

55+
public UpdateValidation validateUpdate(Actor other) {
56+
if (login.equals(other.getLogin())) {
57+
return UpdateValidation.success();
58+
} else {
59+
String errorMessage = String.format("Update of the Actor with ID '%d' failed because only field 'avatar'" +
60+
" can be change. Tried to change the field 'login'", other.getId().getNumber());
61+
return UpdateValidation.error(errorMessage);
62+
}
63+
}
64+
6565
@Value
6666
public static class UpdateValidation {
6767
private final boolean success;

src/main/java/com/hackerrank/github/core/usecases/actor/GetActorsStreakUseCase.java

-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
import java.util.List;
99

1010
public class GetActorsStreakUseCase extends UseCase<UseCase.NoInput, GetActorsStreakUseCase.OutputValues> {
11-
1211
private ActorRepository repository;
1312

1413
public GetActorsStreakUseCase(ActorRepository repository) {

src/main/java/com/hackerrank/github/core/usecases/actor/UpdateActorUseCase.java

-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
import org.springframework.transaction.annotation.Transactional;
1010

1111
public class UpdateActorUseCase extends UseCase<UpdateActorUseCase.InputValues, UpdateActorUseCase.OutputValues> {
12-
1312
private ActorRepository repository;
1413

1514
public UpdateActorUseCase(ActorRepository repository) {

src/main/java/com/hackerrank/github/core/usecases/event/DeleteEventsUseCase.java

-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
import org.springframework.transaction.annotation.Transactional;
77

88
public class DeleteEventsUseCase extends UseCase<UseCase.NoInput, DeleteEventsUseCase.OutputValues> {
9-
109
private EventRepository repository;
1110

1211
public DeleteEventsUseCase(EventRepository repository) {

src/main/java/com/hackerrank/github/core/usecases/event/GetActorEventsUseCase.java

-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
import java.util.List;
1212

1313
public class GetActorEventsUseCase extends UseCase<GetActorEventsUseCase.InputValues, GetActorEventsUseCase.OutputValues> {
14-
1514
private EventRepository eventRepository;
1615
private ActorRepository actorRepository;
1716

src/main/java/com/hackerrank/github/core/usecases/event/GetEventsUseCase.java

-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
import java.util.List;
99

1010
public class GetEventsUseCase extends UseCase<UseCase.NoInput, GetEventsUseCase.OutputValues> {
11-
1211
private EventRepository repository;
1312

1413
public GetEventsUseCase(EventRepository repository) {

src/main/java/com/hackerrank/github/persistence/jpa/repositories/ActorRepositoryImpl.java renamed to src/main/java/com/hackerrank/github/persistence/jpa/repositories/ActorRepositoryAdapter.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@
1212
import static java.util.stream.Collectors.toList;
1313

1414
@Repository
15-
public class ActorRepositoryImpl implements ActorRepository {
15+
public class ActorRepositoryAdapter implements ActorRepository {
1616
private JpaActorRepository jpaRepository;
1717

18-
public ActorRepositoryImpl(JpaActorRepository jpaRepository) {
18+
public ActorRepositoryAdapter(JpaActorRepository jpaRepository) {
1919
this.jpaRepository = jpaRepository;
2020
}
2121

src/main/java/com/hackerrank/github/persistence/jpa/repositories/EventRepositoryImpl.java renamed to src/main/java/com/hackerrank/github/persistence/jpa/repositories/EventRepositoryAdapter.java

+2-3
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,10 @@
1515

1616
@Repository
1717
@Transactional
18-
public class EventRepositoryImpl implements EventRepository {
19-
18+
public class EventRepositoryAdapter implements EventRepository {
2019
private JpaEventRepository jpaEventRepository;
2120

22-
public EventRepositoryImpl(JpaEventRepository jpaEventRepository) {
21+
public EventRepositoryAdapter(JpaEventRepository jpaEventRepository) {
2322
this.jpaEventRepository = jpaEventRepository;
2423
}
2524

src/main/java/com/hackerrank/github/presenter/config/Module.java

-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414

1515
@Configuration
1616
public class Module {
17-
1817
@Bean
1918
public CreateEventUseCase createEventUseCase(EventRepository eventRepository, ActorRepository actorRepository) {
2019
return new CreateEventUseCase(eventRepository, actorRepository);

src/main/java/com/hackerrank/github/presenter/rest/api/actor/ActorResource.java

-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
@RestController
1818
@RequestMapping("/actors")
1919
public interface ActorResource {
20-
2120
@PutMapping
2221
CompletableFuture<ResponseEntity<Object>> create(@Valid @RequestBody ActorRequest request);
2322

src/main/java/com/hackerrank/github/presenter/rest/api/event/CreateEventAdapter.java

-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
import java.net.URI;
1616

1717
public class CreateEventAdapter {
18-
1918
public static ResponseEntity<ResponseEntity<Object>> output(CreateEventUseCase.OutputValues value, HttpServletRequest httpServletRequest) {
2019
URI location = ServletUriComponentsBuilder
2120
.fromContextPath(httpServletRequest)

src/main/java/com/hackerrank/github/presenter/rest/api/event/DeleteAllEventsAdapter.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@
44
import org.springframework.http.ResponseEntity;
55

66
public class DeleteAllEventsAdapter {
7-
8-
public static ResponseEntity<Object> output(DeleteEventsUseCase.OutputValues outputValues) {
7+
public static ResponseEntity<Object> output(DeleteEventsUseCase.OutputValues ignored) {
98
return ResponseEntity.ok().build();
109
}
1110
}

src/main/java/com/hackerrank/github/presenter/rest/api/event/EventResource.java

-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717

1818
@RestController
1919
public interface EventResource {
20-
2120
@DeleteMapping("/erase")
2221
CompletableFuture<ResponseEntity<Object>> deleteAll();
2322

src/main/java/com/hackerrank/github/presenter/rest/api/event/GetAllEventsAdapter.java

-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import static java.util.stream.Collectors.toList;
88

99
public class GetAllEventsAdapter {
10-
1110
public static List<EventResponse> output(GetEventsUseCase.OutputValues outputValues) {
1211
return outputValues
1312
.getEvents()

src/main/java/com/hackerrank/github/presenter/rest/api/shared/GlobalExceptionHandler.java

-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010

1111
@ControllerAdvice
1212
public class GlobalExceptionHandler extends ResponseEntityExceptionHandler {
13-
1413
@ExceptionHandler(value = {BusinessException.class})
1514
ResponseEntity<ApiResponse> handleBusinessErrors(BusinessException ex) {
1615
return new ResponseEntity<>(new ApiResponse(false, ex.getMessage()), HttpStatus.BAD_REQUEST);

src/test/java/com/hackerrank/github/persistence/jpa/repositories/ActorRepositoryImplTest.java renamed to src/test/java/com/hackerrank/github/persistence/jpa/repositories/ActorRepositoryAdapterTest.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,10 @@
2020
import static org.mockito.Mockito.verify;
2121

2222
@RunWith(MockitoJUnitRunner.class)
23-
public class ActorRepositoryImplTest {
23+
public class ActorRepositoryAdapterTest {
2424

2525
@InjectMocks
26-
private ActorRepositoryImpl repository;
26+
private ActorRepositoryAdapter repository;
2727

2828
@Mock
2929
private JpaActorRepository jpaRepository;

src/test/java/com/hackerrank/github/persistence/jpa/repositories/EventRepositoryImplTest.java renamed to src/test/java/com/hackerrank/github/persistence/jpa/repositories/EventRepositoryAdapterTest.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@
2121
import static org.mockito.Mockito.verify;
2222

2323
@RunWith(MockitoJUnitRunner.class)
24-
public class EventRepositoryImplTest {
24+
public class EventRepositoryAdapterTest {
2525

2626
@InjectMocks
27-
private EventRepositoryImpl repository;
27+
private EventRepositoryAdapter repository;
2828

2929
@Mock
3030
private JpaEventRepository jpaEventRepository;

0 commit comments

Comments
 (0)