Skip to content

Diff server should return a 503 status for upstream 503 responses #20

Open
@Mr0grog

Description

@Mr0grog

The diff server usually handles upstream errors (I.e. the result of fetching the URL for either the a or b parameters is an error) by returning a 502 (bad gateway) status. However, if the upstream response was a 503 (service unavailable) status, we should probably return the same, including the upstream Retry-After response header, if present.

503 is often used to tell the requesting server to slow down, so it would be helpful to send that info back to the downstream server, since are just acting dumb in the middle.

In fact, if an upstream response comes back as any error with a Retry-After header, we should probably send along that header to the downstream client.

(We sometimes get this status from S3 when running imports and auto analysis, so it would be nice to handle it better.)

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestserverSpecific to the diffing server, rather than diff algorithms

    Type

    No type

    Projects

    Status

    Inbox

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions