Add diagnostic descriptors to common (#1597)

Author: josefpihrt

ChangeLog.md

@@ -10,7 +10,6 @@
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Roslynator.CodeFixes;
-using Roslynator.CSharp;
 using Roslynator.CSharp.Analysis;
 
 namespace Roslynator.CSharp.CodeFixes;

src/Analyzers.CodeFixes/CSharp/CodeFixes/AddParenthesesWhenNecessaryCodeFixProvider.cs

@@ -9,7 +9,6 @@
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CodeActions;
 using Microsoft.CodeAnalysis.CodeFixes;
-using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Roslynator.CodeFixes;
 

src/Analyzers.CodeFixes/CSharp/CodeFixes/RemoveRedundantCatchBlockCodeFixProvider.cs

@@ -11,7 +11,6 @@
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Roslynator.CodeFixes;
-using Roslynator.CSharp;
 using static Microsoft.CodeAnalysis.CSharp.SyntaxFactory;
 using static Roslynator.CSharp.CSharpFactory;
 

src/Analyzers.CodeFixes/CSharp/CodeFixes/UseAutoPropertyCodeFixProvider.cs

@@ -11,7 +11,6 @@
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Roslynator.CodeFixes;
-using Roslynator.CSharp;
 
 namespace Roslynator.CSharp.CodeFixes;
 

src/Analyzers.CodeFixes/CSharp/CodeFixes/UseExplicitTypeInsteadOfVarCodeFixProvider.cs

@@ -11,7 +11,6 @@
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Roslynator.CodeFixes;
-using Roslynator.CSharp;
 using Roslynator.CSharp.Syntax;
 using static Microsoft.CodeAnalysis.CSharp.SyntaxFactory;
 using static Roslynator.CSharp.CSharpFactory;

src/Analyzers.CodeFixes/CSharp/CodeFixes/UseStringComparisonCodeFixProvider.cs

@@ -10,7 +10,6 @@
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Roslynator.CodeFixes;
-using Roslynator.CSharp;
 using static Roslynator.CSharp.CodeActionFactory;
 
 namespace Roslynator.CSharp.CodeFixes;

src/Analyzers.CodeFixes/CSharp/CodeFixes/UseVarOrExplicitTypeCodeFixProvider.cs

@@ -9,7 +9,6 @@
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
-using Roslynator.CSharp;
 using Roslynator.CSharp.Analysis.Documentation;
 
 namespace Roslynator.CSharp.Refactorings.Documentation;

src/Analyzers.CodeFixes/CSharp/Refactorings/Documentation/DocumentationCommentRefactoring`1.cs

@@ -4,7 +4,6 @@
 using System.Threading.Tasks;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
-using Roslynator.CSharp;
 
 namespace Roslynator.CSharp.Refactorings;
 

src/Analyzers.CodeFixes/CSharp/Refactorings/RemoveRedundantDefaultSwitchSectionRefactoring.cs

@@ -4,7 +4,6 @@
 using System.Threading.Tasks;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
-using Roslynator.CSharp;
 
 namespace Roslynator.CSharp.Refactorings;
 

src/Analyzers.CodeFixes/CSharp/Refactorings/RemoveUnnecessaryCaseLabelRefactoring.cs

@@ -5,7 +5,6 @@
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
-using Roslynator.CSharp;
 using static Microsoft.CodeAnalysis.CSharp.SyntaxFactory;
 using static Roslynator.CSharp.CSharpFactory;
 

src/Analyzers.CodeFixes/CSharp/Refactorings/UnconstrainedTypeParameterCheckedForNullRefactoring.cs

@@ -5,7 +5,6 @@
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
-using Roslynator.CSharp;
 using static Roslynator.CSharp.CSharpFactory;
 
 namespace Roslynator.CSharp.Refactorings;

src/Analyzers.CodeFixes/CSharp/Refactorings/UseExclusiveOrOperatorRefactoring.cs

@@ -5,7 +5,6 @@
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
-using Roslynator.CSharp;
 using static Microsoft.CodeAnalysis.CSharp.SyntaxFactory;
 using static Roslynator.CSharp.CSharpFactory;
 

src/Analyzers.CodeFixes/CSharp/Refactorings/ValueTypeObjectIsNeverEqualToNullRefactoring.cs

@@ -4,8 +4,6 @@
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.Formatting;
-using Roslynator;
-using Roslynator.CSharp;
 using static Microsoft.CodeAnalysis.CSharp.SyntaxFactory;
 using static Roslynator.CSharp.CSharpFactory;
 

src/Analyzers.CodeFixes/CSharp/SyntaxRewriters/UseAsyncAwaitRewriter.cs

@@ -7973,4 +7973,4 @@ class FooCodeFixProvider : CodeFixProvider
       </Sample>
     </Samples>
   </Analyzer>
-</Analyzers>
+</Analyzers>

src/Analyzers.xml

@@ -10,7 +10,6 @@
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.Diagnostics;
 using Microsoft.CodeAnalysis.Text;
-using Roslynator.CSharp;
 using Roslynator.CSharp.CodeStyle;
 
 namespace Roslynator.CSharp.Analysis;

src/Analyzers/CSharp/Analysis/AddOrRemoveAccessibilityModifiersAnalyzer.cs

@@ -5,7 +5,6 @@
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.Diagnostics;
-using Roslynator.CSharp;
 
 namespace Roslynator.CSharp.Analysis;
 

src/Analyzers/CSharp/Analysis/AnonymousMethodAnalyzer.cs

@@ -6,7 +6,6 @@
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.Diagnostics;
-using Roslynator.CSharp;
 
 namespace Roslynator.CSharp.Analysis;
 

src/Analyzers/CSharp/Analysis/BooleanLiteralAnalyzer.cs

@@ -5,7 +5,6 @@
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.Diagnostics;
-using Roslynator.CSharp;
 
 namespace Roslynator.CSharp.Analysis;
 

src/Analyzers/CSharp/Analysis/ConditionalExpressionAnalyzer.cs

@@ -8,7 +8,6 @@
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.Diagnostics;
 using Microsoft.CodeAnalysis.Text;
-using Roslynator.CSharp;
 using Roslynator.CSharp.Syntax;
 using Roslynator.CSharp.SyntaxWalkers;
 

src/Analyzers/CSharp/Analysis/InlineLocalVariableAnalyzer.cs

@@ -7,7 +7,6 @@
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.Diagnostics;
 using Microsoft.CodeAnalysis.Text;
-using Roslynator.CSharp;
 using Roslynator.CSharp.Analysis.UseMethodChaining;
 using Roslynator.CSharp.Syntax;
 

src/Analyzers/CSharp/Analysis/InvocationExpressionAnalyzer.cs

@@ -5,7 +5,6 @@
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.Diagnostics;
-using Roslynator.CSharp;
 using Roslynator.CSharp.CodeStyle;
 using Roslynator.CSharp.Syntax;
 

src/Analyzers/CSharp/Analysis/NormalizeNullCheckAnalyzer.cs

@@ -4,7 +4,6 @@
 using System.Collections.Generic;
 using System.Collections.Immutable;
 using System.Diagnostics;
-using System.Linq;
 using System.Threading;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CSharp;

src/Analyzers/CSharp/Analysis/OptimizeLinqMethodCallAnalysis.cs

@@ -8,7 +8,6 @@
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.Diagnostics;
-using Roslynator.CSharp.SyntaxWalkers;
 
 namespace Roslynator.CSharp.Analysis;
 

src/Analyzers/CSharp/Analysis/RemoveOriginalExceptionFromThrowStatementAnalyzer.cs

@@ -6,7 +6,6 @@
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.Diagnostics;
-using Roslynator.CSharp;
 
 namespace Roslynator.CSharp.Analysis;
 

src/Analyzers/CSharp/Analysis/RemoveRedundantAsyncAwaitAnalyzer.cs

@@ -6,7 +6,6 @@
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.Diagnostics;
-using Roslynator.CSharp;
 
 namespace Roslynator.CSharp.Analysis;
 

src/Analyzers/CSharp/Analysis/RemoveRedundantDefaultSwitchSectionAnalyzer.cs

@@ -7,7 +7,6 @@
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.Diagnostics;
-using Roslynator.CSharp;
 using Roslynator.CSharp.Syntax;
 
 namespace Roslynator.CSharp.Analysis;

src/Analyzers/CSharp/Analysis/RemoveRedundantOverridingMemberAnalyzer.cs

@@ -1,12 +1,10 @@
 // Copyright (c) .NET Foundation and Contributors. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
 using System.Collections.Immutable;
-using System.Linq;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.Diagnostics;
-using Roslynator.CSharp;
 
 namespace Roslynator.CSharp.Analysis;
 

src/Analyzers/CSharp/Analysis/RemoveUnnecessaryCaseLabelAnalyzer.cs

@@ -4,7 +4,6 @@
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.Diagnostics;
-using Roslynator.CSharp;
 
 namespace Roslynator.CSharp.Analysis;
 

src/Analyzers/CSharp/Analysis/SimplifyBooleanComparisonAnalysis.cs

@@ -5,7 +5,6 @@
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.Diagnostics;
-using Roslynator.CSharp;
 
 namespace Roslynator.CSharp.Analysis;
 

src/Analyzers/CSharp/Analysis/SimplifyNestedUsingStatementAnalyzer.cs

@@ -6,7 +6,6 @@
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.Diagnostics;
-using Roslynator.CSharp;
 
 namespace Roslynator.CSharp.Analysis;
 

src/Analyzers/CSharp/Analysis/SimplifyNullableOfTAnalyzer.cs

@@ -1,6 +1,5 @@
 // Copyright (c) .NET Foundation and Contributors. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-using System;
 using System.Collections.Immutable;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CSharp;

src/Analyzers/CSharp/Analysis/UnnecessaryUnsafeContextAnalyzer.cs

@@ -9,7 +9,6 @@
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.Diagnostics;
-using Roslynator.CSharp;
 using Roslynator.CSharp.SyntaxWalkers;
 
 namespace Roslynator.CSharp.Analysis;

src/Analyzers/CSharp/Analysis/UseAutoPropertyAnalyzer.cs

@@ -5,7 +5,6 @@
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.Diagnostics;
-using Roslynator.CSharp;
 using Roslynator.CSharp.CodeStyle;
 
 namespace Roslynator.CSharp.Analysis;

src/Analyzers/CSharp/Analysis/UseBlockBodyOrExpressionBodyAnalyzer.cs

@@ -9,7 +9,6 @@
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.Diagnostics;
 using Microsoft.CodeAnalysis.Text;
-using Roslynator.CSharp;
 using Roslynator.CSharp.Syntax;
 
 namespace Roslynator.CSharp.Analysis;

src/Analyzers/CSharp/Analysis/UseConditionalAccessAnalyzer.cs

@@ -5,7 +5,6 @@
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.Diagnostics;
-using Roslynator.CSharp;
 using Roslynator.CSharp.Syntax;
 using static Roslynator.CSharp.CSharpFactory;
 

src/Analyzers/CSharp/Analysis/UseExclusiveOrOperatorAnalyzer.cs

@@ -8,7 +8,6 @@
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.Diagnostics;
 using Microsoft.CodeAnalysis.Text;
-using Roslynator.CSharp;
 using Roslynator.CSharp.Syntax;
 
 namespace Roslynator.CSharp.Analysis;

src/Analyzers/CSharp/Analysis/UseNameOfOperatorAnalyzer.cs

@@ -7,7 +7,6 @@
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.Diagnostics;
-using Roslynator.CSharp;
 using Roslynator.CSharp.Syntax;
 
 namespace Roslynator.CSharp.Analysis;

src/Analyzers/CSharp/Analysis/UseStringComparisonAnalysis.cs

@@ -7,7 +7,6 @@
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.Diagnostics;
-using Roslynator.CSharp;
 using Roslynator.CSharp.Syntax;
 
 namespace Roslynator.CSharp.Analysis;

src/Analyzers/CSharp/Analysis/UseStringIsNullOrEmptyMethodAnalyzer.cs

@@ -3,7 +3,6 @@
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.Host.Mef;
-using Roslynator.CSharp;
 
 namespace Roslynator.CSharp;
 

src/CSharp.Workspaces/CSharp/CSharpSyntaxFactsService.cs

@@ -2,7 +2,6 @@
 
 using System;
 using System.Collections.Generic;
-using System.Collections.Immutable;
 using System.Diagnostics;
 using System.Linq;
 using System.Threading;
@@ -16,7 +15,6 @@
 using Roslynator.CSharp.SyntaxWalkers;
 using Roslynator.Documentation;
 using static Microsoft.CodeAnalysis.CSharp.SyntaxFactory;
-using static Roslynator.CSharp.CSharpFactory;
 
 namespace Roslynator.CSharp;
 

src/CSharp/CSharp/Extensions/SyntaxExtensions.cs

@@ -24,7 +24,7 @@ public sealed class AttributeArgumentCodeFixProvider : BaseCodeFixProvider
 
     public override ImmutableArray<string> FixableDiagnosticIds
     {
-        get { return ImmutableArray.Create(DiagnosticIdentifiers.UnknownLanguageName); }
+        get { return ImmutableArray.Create(CodeAnalysisDiagnosticIdentifiers.UnknownLanguageName); }
     }
 
     public override async Task RegisterCodeFixesAsync(CodeFixContext context)
@@ -39,7 +39,7 @@ public override async Task RegisterCodeFixesAsync(CodeFixContext context)
 
         switch (diagnostic.Id)
         {
-            case DiagnosticIdentifiers.UnknownLanguageName:
+            case CodeAnalysisDiagnosticIdentifiers.UnknownLanguageName:
             {
                 foreach (string languageName in RoslynUtility.WellKnownLanguageNames)
                 {

src/CodeAnalysis.Analyzers.CodeFixes/CSharp/AttributeArgumentCodeFixProvider.cs

@@ -23,8 +23,8 @@ public override ImmutableArray<string> FixableDiagnosticIds
         get
         {
             return ImmutableArray.Create(
-                DiagnosticIdentifiers.SpecifyExportCodeFixProviderAttributeName,
-                DiagnosticIdentifiers.SpecifyExportCodeRefactoringProviderAttributeName);
+                CodeAnalysisDiagnosticIdentifiers.SpecifyExportCodeFixProviderAttributeName,
+                CodeAnalysisDiagnosticIdentifiers.SpecifyExportCodeRefactoringProviderAttributeName);
         }
     }
 
@@ -40,8 +40,8 @@ public override async Task RegisterCodeFixesAsync(CodeFixContext context)
 
         switch (diagnostic.Id)
         {
-            case DiagnosticIdentifiers.SpecifyExportCodeFixProviderAttributeName:
-            case DiagnosticIdentifiers.SpecifyExportCodeRefactoringProviderAttributeName:
+            case CodeAnalysisDiagnosticIdentifiers.SpecifyExportCodeFixProviderAttributeName:
+            case CodeAnalysisDiagnosticIdentifiers.SpecifyExportCodeRefactoringProviderAttributeName:
             {
                 CodeAction codeAction = CodeAction.Create(
                     "Specify name",