Windows suggestions stops working in 16.3

[EdiDD]

Describe the bug
After update to 16.3 none of the suggestions works anymore neither tiling nor snap nor egde

To Reproduce
Steps to reproduce the behavior:
Enable any of suggestions

Information (please complete the following):

• Tiling Shell version: 16.3
• GNOME version: 48

[domferr]

Hey, this is strange, thank you for sharing! I am not able to reproduce the problem, since it is working when I enable any of the suggestions. Do you see any other issues which may cause this bug?

[h44z]

@domferr the error message I can see in the log is as follows:

Mär 30 21:43:27 coreship gnome-shell[1716]: Error in size change accounting.
Mär 30 21:43:28 coreship gnome-shell[1716]: Error in size change accounting.
Mär 30 21:43:31 coreship gnome-shell[1716]: Error in size change accounting.
Mär 30 21:43:33 coreship gnome-shell[1716]: Error in size change accounting.
Mär 30 21:43:35 coreship gnome-shell[1716]: JS ERROR: TypeError: this._scrollView.get_hscroll_bar is not a function
                                           SuggestionsTilePreview@file:///home/h44z/.local/share/gnome-shell/extensions/[email protected]/extension.js:3508:22
                                           buildTile@file:///home/h44z/.local/share/gnome-shell/extensions/[email protected]/extension.js:3654:12
                                           draw_layout/this._previews<@file:///home/h44z/.local/share/gnome-shell/extensions/[email protected]/extension.js:1276:19
                                           draw_layout@file:///home/h44z/.local/share/gnome-shell/extensions/[email protected]/extension.js:1253:41
                                           relayout@file:///home/h44z/.local/share/gnome-shell/extensions/[email protected]/extension.js:1320:10
                                           _openWindowsSuggestions@file:///home/h44z/.local/share/gnome-shell/extensions/[email protected]/extension.js:4521:35
                                           _onWindowGrabEnd@file:///home/h44z/.local/share/gnome-shell/extensions/[email protected]/extension.js:4493:10
                                           enable/<@file:///home/h44z/.local/share/gnome-shell/extensions/[email protected]/extension.js:4013:14
                                           @resource:///org/gnome/shell/ui/init.js:21:20
Mär 30 21:43:35 coreship gnome-shell[1716]: Error in size change accounting.

[EdiDD]

@domferr I can't see any other issue. Only suggestions don't work.

[domferr]

Thank you! Can you confirm the issue is solved?

For GNOME 45+: [email protected]

[h44z]

@domferr for me, this release made it worse. A blue area stays on the screen as soon as I tile one window, see screenshots. After that, window management is broken.

[domferr]

Thank you @h44z, did you notice any particular log or error? Can you share how I can reproduce this problem?

[h44z]

@domferr just tried it again, and there is an error message:

Apr 12 22:56:41 obelix gnome-shell[3518]: g_object_set_is_valid_property: construct property "window-container" for object 'PopupWindowPreview' can't be set after construction
Apr 12 22:56:41 obelix gnome-shell[3518]: JS ERROR: TypeError: this.window_container is null
                                          _addWindow@file:///home/h44z/.local/share/gnome-shell/extensions/[email protected]/extension.js:3191:5
                                          SuggestedWindowPreview@file:///home/h44z/.local/share/gnome-shell/extensions/[email protected]/extension.js:3051:10
                                          _recursivelyShowPopup/clones<@file:///home/h44z/.local/share/gnome-shell/extensions/[email protected]/extension.js:3743:24
                                          _recursivelyShowPopup@file:///home/h44z/.local/share/gnome-shell/extensions/[email protected]/extension.js:3742:36
                                          open@file:///home/h44z/.local/share/gnome-shell/extensions/[email protected]/extension.js:3689:10
                                          _openWindowsSuggestions@file:///home/h44z/.local/share/gnome-shell/extensions/[email protected]/extension.js:4543:35
                                          _onWindowGrabEnd@file:///home/h44z/.local/share/gnome-shell/extensions/[email protected]/extension.js:4514:10
                                          enable/<@file:///home/h44z/.local/share/gnome-shell/extensions/[email protected]/extension.js:4034:14
                                          @resource:///org/gnome/shell/ui/init.js:21:20

To reproduce this, simply open two windows, resize them so that they float freely, and then drag one window to a tiled section (it does not matter if you use the top bar or press control). Once the window is in its tile, the remaining tiles are highlighted in blue and everything is unresponsive.

[domferr]

Thanks a million @h44z! I'm having issues running my GNOME 48 OS virtual machine and your insights really helped!

[domferr]

Here it is a fix! Let me know if it works, thank you!

[email protected]

[shdwchn10]

Here it is a fix! Let me know if it works, thank you!

[email protected]

Now window suggestions work with snap assistant, edge snapping and while moving windows with Ctrl! But suggestions still don't appear when using shortcuts (Super+↑↓←→)

Fedora Silverblue 42, GNOME Shell 48.1

[domferr]

Thank you for your feedback! @shdwchn10 yeah, that feature is currently not implemented