Skip to content

Extracting Downloader into a dedicated lib ? #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fcamblor opened this issue Feb 1, 2016 · 1 comment
Open

Extracting Downloader into a dedicated lib ? #19

fcamblor opened this issue Feb 1, 2016 · 1 comment

Comments

@fcamblor
Copy link

fcamblor commented Feb 1, 2016

Hi,

I'd love to re-use the net.codestory.simplelenium.driver.Downloader (alongside its Configuration & LockFile dependencies) into my project, which is not really selenium-related nor testing-stuff-related thing
(In fact, it is only intended to be a PhantomJS provisioner)

Would you see any benefit of creating a new dedicated lib for this (you may have already faced this need ?) or should I fork & create it on my own ?

If you're interested in it, I can create a PR for this (however, it will require you to create a new repository for hosting it ... and I would be more in favour that you, the author for these 3 classes, host it than I do own it :-))
Tell me WDYT, I'll do what you prefer.

@fcamblor
Copy link
Author

fcamblor commented Feb 1, 2016

FYI, it may look like something like this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant