Merge pull request #43 from KamilWitkowski7/master

chore: change state of following OOP hermetization rules

Author: pilloPl

src/main/java/io/pillopl/library/catalogue/Book.java

@@ -1,13 +1,14 @@
 package io.pillopl.library.catalogue;
 
+import lombok.AccessLevel;
 import lombok.AllArgsConstructor;
 import lombok.EqualsAndHashCode;
 import lombok.NonNull;
 import lombok.Value;
 
 @Value
 @EqualsAndHashCode(of = "bookIsbn")
-@AllArgsConstructor
+@AllArgsConstructor(access = AccessLevel.PACKAGE)
 class Book {
 
     @NonNull

src/main/java/io/pillopl/library/catalogue/BookInstance.java

@@ -1,13 +1,14 @@
 package io.pillopl.library.catalogue;
 
+import lombok.AccessLevel;
 import lombok.AllArgsConstructor;
 import lombok.NonNull;
 import lombok.Value;
 
 import java.util.UUID;
 
 @Value
-@AllArgsConstructor
+@AllArgsConstructor(access = AccessLevel.PRIVATE)
 class BookInstance {
 
     @NonNull

src/main/java/io/pillopl/library/catalogue/BookInstanceAddedToCatalogue.java

@@ -1,14 +1,15 @@
 package io.pillopl.library.catalogue;
 
 import io.pillopl.library.commons.events.DomainEvent;
+import lombok.AccessLevel;
 import lombok.AllArgsConstructor;
 import lombok.Value;
 
 import java.time.Instant;
 import java.util.UUID;
 
 @Value
-@AllArgsConstructor
+@AllArgsConstructor(access = AccessLevel.PACKAGE)
 public class BookInstanceAddedToCatalogue implements DomainEvent {
 
     UUID eventId = UUID.randomUUID();

src/main/java/io/pillopl/library/catalogue/Catalogue.java

@@ -3,12 +3,13 @@
 import io.pillopl.library.commons.commands.Result;
 import io.pillopl.library.commons.events.DomainEvents;
 import io.vavr.control.Try;
+import lombok.AccessLevel;
 import lombok.AllArgsConstructor;
 
 import static io.pillopl.library.commons.commands.Result.Rejection;
 import static io.pillopl.library.commons.commands.Result.Success;
 
-@AllArgsConstructor
+@AllArgsConstructor(access = AccessLevel.PACKAGE)
 public class Catalogue {
 
     private final CatalogueDatabase database;

src/main/java/io/pillopl/library/catalogue/CatalogueDatabase.java

@@ -1,14 +1,15 @@
 package io.pillopl.library.catalogue;
 
 import io.vavr.control.Option;
+import lombok.AccessLevel;
 import lombok.AllArgsConstructor;
 import lombok.Data;
 import lombok.NoArgsConstructor;
 import org.springframework.dao.EmptyResultDataAccessException;
 import org.springframework.jdbc.core.BeanPropertyRowMapper;
 import org.springframework.jdbc.core.JdbcTemplate;
 
-@AllArgsConstructor
+@AllArgsConstructor(access = AccessLevel.PACKAGE)
 class CatalogueDatabase {
 
     private final JdbcTemplate jdbcTemplate;
@@ -48,7 +49,7 @@ Option<Book> findBy(ISBN isbn) {
 }
 
 @Data
-@NoArgsConstructor
+@NoArgsConstructor(access = AccessLevel.PACKAGE)
 class BookDatabaseRow {
     String isbn;
     String author;

src/main/java/io/pillopl/library/lending/book/infrastructure/BookDatabaseRepository.java

@@ -9,6 +9,7 @@
 import io.pillopl.library.lending.patron.model.PatronId;
 import io.vavr.control.Option;
 import io.vavr.control.Try;
+import lombok.AccessLevel;
 import lombok.AllArgsConstructor;
 import org.springframework.jdbc.core.BeanPropertyRowMapper;
 import org.springframework.jdbc.core.JdbcTemplate;
@@ -23,7 +24,7 @@
 import static io.vavr.control.Option.none;
 import static io.vavr.control.Option.of;
 
-@AllArgsConstructor
+@AllArgsConstructor(access = AccessLevel.PACKAGE)
 class BookDatabaseRepository implements BookRepository, FindAvailableBook, FindBookOnHold {
 
     private final JdbcTemplate jdbcTemplate;

src/main/java/io/pillopl/library/lending/book/model/BookOnHold.java

@@ -9,6 +9,7 @@
 import io.pillopl.library.lending.patron.model.PatronEvent.BookHoldExpired;
 import io.pillopl.library.lending.patron.model.PatronEvent.BookReturned;
 import io.pillopl.library.lending.patron.model.PatronId;
+import lombok.AccessLevel;
 import lombok.AllArgsConstructor;
 import lombok.EqualsAndHashCode;
 import lombok.NonNull;
@@ -17,7 +18,7 @@
 import java.time.Instant;
 
 @Value
-@AllArgsConstructor
+@AllArgsConstructor(access = AccessLevel.PACKAGE)
 @EqualsAndHashCode(of = "bookInformation")
 public class BookOnHold implements Book {
 

src/main/java/io/pillopl/library/lending/book/model/CheckedOutBook.java

@@ -6,13 +6,14 @@
 import io.pillopl.library.lending.librarybranch.model.LibraryBranchId;
 import io.pillopl.library.lending.patron.model.PatronEvent;
 import io.pillopl.library.lending.patron.model.PatronId;
+import lombok.AccessLevel;
 import lombok.AllArgsConstructor;
 import lombok.EqualsAndHashCode;
 import lombok.NonNull;
 import lombok.Value;
 
 @Value
-@AllArgsConstructor
+@AllArgsConstructor(access = AccessLevel.PACKAGE)
 @EqualsAndHashCode(of = "bookInformation")
 public class CheckedOutBook implements Book {
 

src/main/java/io/pillopl/library/lending/dailysheet/infrastructure/SheetsReadModel.java

@@ -14,6 +14,7 @@
 import io.pillopl.library.lending.patron.model.PatronEvent.BookReturned;
 import io.pillopl.library.lending.patron.model.PatronId;
 import io.vavr.control.Option;
+import lombok.AccessLevel;
 import lombok.AllArgsConstructor;
 import org.springframework.context.event.EventListener;
 import org.springframework.dao.DuplicateKeyException;
@@ -32,7 +33,7 @@
 import static java.sql.Timestamp.from;
 import static java.util.stream.Collectors.toList;
 
-@AllArgsConstructor
+@AllArgsConstructor(access = AccessLevel.PACKAGE)
 class SheetsReadModel implements DailySheet {
 
     private final JdbcTemplate sheets;

src/main/java/io/pillopl/library/lending/patron/infrastructure/HoldDatabaseEntity.java

@@ -1,13 +1,14 @@
 package io.pillopl.library.lending.patron.infrastructure;
 
+import lombok.AccessLevel;
 import lombok.Getter;
 import lombok.NoArgsConstructor;
 import org.springframework.data.annotation.Id;
 
 import java.time.Instant;
 import java.util.UUID;
 
-@NoArgsConstructor
+@NoArgsConstructor(access = AccessLevel.PACKAGE)
 @Getter
 class HoldDatabaseEntity {
 

src/main/java/io/pillopl/library/lending/patron/infrastructure/OverdueCheckoutDatabaseEntity.java

@@ -1,13 +1,14 @@
 package io.pillopl.library.lending.patron.infrastructure;
 
+import lombok.AccessLevel;
 import lombok.EqualsAndHashCode;
 import lombok.Getter;
 import lombok.NoArgsConstructor;
 import org.springframework.data.annotation.Id;
 
 import java.util.UUID;
 
-@NoArgsConstructor
+@NoArgsConstructor(access = AccessLevel.PACKAGE)
 @EqualsAndHashCode
 @Getter
 class OverdueCheckoutDatabaseEntity {

src/main/java/io/pillopl/library/lending/patron/infrastructure/PatronDatabaseEntity.java

@@ -6,6 +6,7 @@
 import io.pillopl.library.lending.patron.model.PatronId;
 import io.pillopl.library.lending.patron.model.PatronType;
 import io.vavr.API;
+import lombok.AccessLevel;
 import lombok.NoArgsConstructor;
 import org.springframework.data.annotation.Id;
 
@@ -17,7 +18,7 @@
 import static io.vavr.API.Case;
 import static io.vavr.Predicates.instanceOf;
 
-@NoArgsConstructor
+@NoArgsConstructor(access = AccessLevel.PACKAGE)
 class PatronDatabaseEntity {
 
     @Id

src/main/java/io/pillopl/library/lending/patron/infrastructure/PatronsDatabaseRepository.java

@@ -8,6 +8,7 @@
 import io.vavr.Tuple;
 import io.vavr.Tuple2;
 import io.vavr.control.Option;
+import lombok.AccessLevel;
 import lombok.AllArgsConstructor;
 import org.springframework.data.jdbc.repository.query.Query;
 import org.springframework.data.repository.CrudRepository;
@@ -22,7 +23,7 @@
 import static io.vavr.Predicates.instanceOf;
 import static java.util.stream.Collectors.*;
 
-@AllArgsConstructor
+@AllArgsConstructor(access = AccessLevel.PACKAGE)
 class PatronsDatabaseRepository implements Patrons {
 
     private final PatronEntityRepository patronEntityRepository;

src/main/java/io/pillopl/library/lending/patron/model/Patron.java

@@ -8,6 +8,7 @@
 import io.vavr.collection.List;
 import io.vavr.control.Either;
 import io.vavr.control.Option;
+import lombok.AccessLevel;
 import lombok.AllArgsConstructor;
 import lombok.EqualsAndHashCode;
 import lombok.NonNull;
@@ -24,7 +25,7 @@
 import static io.pillopl.library.lending.patron.model.PatronHolds.MAX_NUMBER_OF_HOLDS;
 import static io.pillopl.library.lending.patron.model.Rejection.withReason;
 
-@AllArgsConstructor
+@AllArgsConstructor(access = AccessLevel.PACKAGE)
 @EqualsAndHashCode(of = "patron")
 public class Patron {
 

src/main/java/io/pillopl/library/lending/patronprofile/infrastructure/PatronProfileReadModel.java

@@ -8,6 +8,7 @@
 import io.pillopl.library.lending.patronprofile.model.HoldsView;
 import io.pillopl.library.lending.patronprofile.model.PatronProfile;
 import io.pillopl.library.lending.patronprofile.model.PatronProfiles;
+import lombok.AccessLevel;
 import lombok.AllArgsConstructor;
 import org.springframework.jdbc.core.ColumnMapRowMapper;
 import org.springframework.jdbc.core.JdbcTemplate;
@@ -20,7 +21,7 @@
 import static io.vavr.collection.List.ofAll;
 import static java.util.stream.Collectors.toList;
 
-@AllArgsConstructor
+@AllArgsConstructor(access = AccessLevel.PACKAGE)
 class PatronProfileReadModel implements PatronProfiles {
 
     private final JdbcTemplate sheets;