Skip to content

Commit 1974ad0

Browse files
committed
fix readme
1 parent 56df62e commit 1974ad0

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ KAGGLE_KEY=<your_kaggle_key>
6464

6565
This codebase is designed to be run with [Docker](https://docs.docker.com/get-docker/).
6666

67-
If you've never used Docker before, don't worry! I have included a guide to Docker in the [Docker README](./docs/docker.md) file in this repository. This includes a full run through of why Docker is awesome and a brief guide to the `Dockerfile` and `docker compose.yml` for this project.
67+
If you've never used Docker before, don't worry! I have included a guide to Docker in the [Docker README](./docs/docker.md) file in this repository. This includes a full run through of why Docker is awesome and a brief guide to the `Dockerfile` and `docker-compose.yml` for this project.
6868

6969
### Building the Docker image
7070

docs/docker.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -68,11 +68,11 @@ ENV PYTHONPATH="${PYTHONPATH}:/app" #<7>
6868

6969
You can see how the Dockerfile can be thought of as a recipe for building a particular run-time environment. The magic of Docker is that you do not need to worry about installing a resource intensive virtual machine on your computer - Docker is lightweight and allows you to build an environment template purely using code.
7070

71-
A running version of an image is called a *container*. You can think of the image as like a cookie cutter, that can be used to create a particular cookie (the container). There is one other file that we need to look at before we finally get to build our image and run the container - the docker compose.yaml file.
71+
A running version of an image is called a *container*. You can think of the image as like a cookie cutter, that can be used to create a particular cookie (the container). There is one other file that we need to look at before we finally get to build our image and run the container - the docker-compose.yaml file.
7272

73-
## 🎼 The docker compose.yaml file
73+
## 🎼 The docker-compose.yaml file
7474

75-
Docker Compose is an extension to Docker that allows you to define how you would like your containers to run, through a simple YAML file, called 'docker compose.yaml'.
75+
Docker Compose is an extension to Docker that allows you to define how you would like your containers to run, through a simple YAML file, called 'docker-compose.yaml'.
7676

7777
For example, you can specify which ports and folders should be mapped between your machine and the container. Folder mapping allows the container to treat folders on your machine as if they were folders inside the container. Therefore any changes you make to mapped files and folders on your machine will be immediately reflected inside the container. Port mapping will forward any traffic on a local port through to the container. For example, we could map port 8888 on your local machine to port 8888 in the container, so that if you visit `localhost:8888` in your browser, you will see Jupyter, which is running on port 8888 inside the container. The ports do not have have to be the same - for example you could map port 8000 to port 8888 in the container if you wanted.
7878

@@ -103,7 +103,7 @@ services: #<2>
103103
1. This specifies the version of Docker Compose to use (currently version 3)
104104
2. Here, we specify the services we wish to launch
105105
3. We only have one service, which we call `app`
106-
4. Here, we tell Docker where to find the Dockerfile (the same directory as the docker compose.yaml file)
106+
4. Here, we tell Docker where to find the Dockerfile (the same directory as the docker-compose.yaml file)
107107
5. This allows us to open up an interactive command line inside the container, if we wish
108108
6. Here, we map folders on our local machine (e.g. ./data), to folders inside the container (e.g. /app/data).
109109
7. Here, we specify the port mappings - the dollar sign means that it will use the ports as specified in the `.env` file (e.g. `JUPYTER_PORT=8888`)
@@ -128,13 +128,13 @@ docker compose up
128128

129129
You should see that Docker launches the Jupyter notebook server within the container and provides you with a URL to the running server.
130130

131-
Because we have mapped port 8888 in the container to port 8888 on your machine, you can simply navigate to the address starting `http://127.0.0.1:8888/lab?token=` into a web browser and you should see the running Jupyter server. The folders that we mapped across in the `docker compose.yaml` file should be visible on the left hand side.
131+
Because we have mapped port 8888 in the container to port 8888 on your machine, you can simply navigate to the address starting `http://127.0.0.1:8888/lab?token=` into a web browser and you should see the running Jupyter server. The folders that we mapped across in the `docker-compose.yaml` file should be visible on the left hand side.
132132

133133
Congratulations! You now have a functioning Docker container that you can use to start working through the Generative Deep Learning codebase! To stop running the Jupyter server, you use `Ctrl-C` and to bring down the running container, you use the command `docker compose down`. Because the volumes are mapped, you won't lose any of your work that you save whilst working in the Jupyter notebooks, even if you bring the container down.
134134

135135
## ⚡️ Using a GPU
136136

137-
The default `Dockerfile` and `docker compose.yaml` file assume that you do not want to use a local GPU to train your models. If you do have a GPU that you wish to use (for example, you are using a cloud VM), I have provided two extra files called `Dockerfile-gpu` and `docker-compose.gpu.yml` files that can be used in place of the default files.
137+
The default `Dockerfile` and `docker-compose.yaml` file assume that you do not want to use a local GPU to train your models. If you do have a GPU that you wish to use (for example, you are using a cloud VM), I have provided two extra files called `Dockerfile-gpu` and `docker-compose.gpu.yml` files that can be used in place of the default files.
138138

139139
For example, to build an image that includes support for GPU, use the command shown below:
140140

0 commit comments

Comments
 (0)