Skip to content

Commit 38c1a38

Browse files
authored
Merge pull request #2 from databrickslabs/release
Refactored for proper folder structure, and allowed processing of emp…
2 parents 6b67c59 + 0935723 commit 38c1a38

File tree

10 files changed

+10
-9
lines changed

10 files changed

+10
-9
lines changed

src/main/scala/com/databricks/smolder/labs/Segment.scala renamed to src/main/scala/com/databricks/labs/smolder/Segment.scala

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,10 @@ private[smolder] object Segment {
3434
require(segment.nonEmpty, "Received empty segment.")
3535

3636
// assume pipe delimited
37+
//@TODO: pull delimiter from MSH segment
3738
val fields = segment.split('|').map(UTF8String.fromString(_))
3839

39-
require(fields.size > 1,
40+
require(fields.size >= 1,
4041
"Encountered message segment with insufficient fields: %s".format(segment))
4142

4243
Segment(fields.head, fields.tail)

src/test/scala/com/databricks/smolder/labs/SegmentSuite.scala renamed to src/test/scala/com/databricks/labs/smolder/SegmentSuite.scala

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,18 +19,18 @@ import org.scalatest.FunSuite
1919

2020
class SegmentSuite extends FunSuite {
2121

22-
test("cannot parse empty segment") {
22+
test("cannot parse empty segment") {
2323
intercept[IllegalArgumentException] {
2424
Segment("")
2525
}
2626
}
27-
28-
test("cannot parse segment that only contains an ID") {
29-
intercept[IllegalArgumentException] {
30-
Segment("PD1")
31-
}
32-
}
33-
27+
/*
28+
test("cannot parse segment that only contains an ID") {
29+
intercept[IllegalArgumentException] {
30+
Segment("PD1")
31+
}
32+
}
33+
*/
3434
test("properly parse a simple message") {
3535
val id = "PD1"
3636
val fields = Seq("",

0 commit comments

Comments
 (0)