FIX: Fix cppcheck warnings

Author: threecgreen

.github/workflows/build.yaml

@@ -24,7 +24,7 @@ jobs:
           sudo apt-get install libpcre3 libpcre3-dev libzstd-dev ninja-build
       - name: Install cppcheck
         run: |
-          git clone https://github.com/danmar/cppcheck.git --branch 2.14.1
+          git clone https://github.com/danmar/cppcheck.git --branch 2.17.1
           cd cppcheck
           cmake -S. -B build \
             -DCMAKE_BUILD_TYPE=Release \

include/databento/detail/dbn_buffer_decoder.hpp

@@ -6,7 +6,6 @@
 
 #include "databento/detail/buffer.hpp"
 #include "databento/detail/zstd_stream.hpp"
-#include "databento/ireadable.hpp"
 #include "databento/record.hpp"
 #include "databento/timeseries.hpp"
 
@@ -18,7 +17,8 @@ class DbnBufferDecoder {
                    const RecordCallback& record_callback)
       : metadata_callback_{metadata_callback},
         record_callback_{record_callback},
-        zstd_stream_{InitZstdBuffer()} {}
+        zstd_stream_{std::make_unique<Buffer>()},
+        zstd_buffer_{static_cast<Buffer*>(zstd_stream_.Input())} {}
 
   KeepGoing Process(const char* data, std::size_t length);
 
@@ -29,12 +29,6 @@ class DbnBufferDecoder {
     Records,
   };
 
-  std::unique_ptr<IReadable> InitZstdBuffer() {
-    auto zstd_buffer = std::make_unique<Buffer>();
-    zstd_buffer_ = zstd_buffer.get();
-    return zstd_buffer;
-  }
-
   const MetadataCallback& metadata_callback_;
   const RecordCallback& record_callback_;
   ZstdDecodeStream zstd_stream_;
@@ -43,7 +37,7 @@ class DbnBufferDecoder {
   std::size_t bytes_needed_{};
   alignas(RecordHeader) std::array<std::byte, kMaxRecordLen> compat_buffer_{};
   std::uint8_t input_version_{};
-  bool ts_out_;
+  bool ts_out_{};
   DecoderState state_{DecoderState::Init};
 };
 }  // namespace databento::detail

include/databento/detail/zstd_stream.hpp

@@ -23,6 +23,8 @@ class ZstdDecodeStream : public IReadable {
   // return 0 if the end of the stream is reached.
   std::size_t ReadSome(std::byte* buffer, std::size_t max_length) override;
 
+  IReadable* Input() const { return input_.get(); }
+
  private:
   std::unique_ptr<IReadable> input_;
   std::unique_ptr<ZSTD_DStream, std::size_t (*)(ZSTD_DStream*)> z_dstream_;

src/dbn_decoder.cpp

@@ -21,7 +21,7 @@ using databento::DbnDecoder;
 namespace {
 template <typename T>
 T Consume(const std::byte*& buf) {
-  const auto res = *reinterpret_cast<const T*>(&*buf);
+  const auto res = *reinterpret_cast<const T*>(buf);
   buf += sizeof(T);
   return res;
 }
@@ -34,7 +34,7 @@ std::uint8_t Consume(const std::byte*& buf) {
 }
 
 const char* Consume(const std::byte*& buf, const std::ptrdiff_t num_bytes) {
-  const auto* pos = &*buf;
+  const auto* pos = buf;
   buf += num_bytes;
   return reinterpret_cast<const char*>(pos);
 }

src/historical.cpp

@@ -14,7 +14,6 @@
 
 #include "databento/constants.hpp"
 #include "databento/datetime.hpp"
-#include "databento/dbn_decoder.hpp"
 #include "databento/dbn_file_store.hpp"
 #include "databento/detail/dbn_buffer_decoder.hpp"
 #include "databento/detail/json_helpers.hpp"
@@ -24,7 +23,6 @@
 #include "databento/log.hpp"
 #include "databento/metadata.hpp"
 #include "databento/timeseries.hpp"
-#include "dbn_constants.hpp"
 
 using databento::Historical;
 
@@ -676,7 +674,6 @@ double Historical::MetadataGetCost(
     const std::string& dataset, const DateTimeRange<UnixNanos>& datetime_range,
     const std::vector<std::string>& symbols, Schema schema, FeedMode mode,
     SType stype_in, std::uint64_t limit) {
-  static const std::string kPath = ::BuildMetadataPath(".get_cost");
   httplib::Params params{
       {"dataset", dataset},
       {"start", ToString(datetime_range.start)},
@@ -693,7 +690,6 @@ double Historical::MetadataGetCost(
     const DateTimeRange<std::string>& datetime_range,
     const std::vector<std::string>& symbols, Schema schema, FeedMode mode,
     SType stype_in, std::uint64_t limit) {
-  static const std::string kPath = ::BuildMetadataPath(".get_cost");
   httplib::Params params{
       {"dataset", dataset},
       {"start", datetime_range.start},