Skip to content

Missing peak in chrom.map_peaks() exits loop #23

Open
@connor-pl-delaney

Description

@connor-pl-delaney

Thanks for making this package - it's really well done!

I noticed that if a mapped peak is absent from the peak list, all subsequent mappings are ignored, even if they are present in the chromatogram. I traced the issue back to line 1060 of quant.py, where the loop breaks when an absent peak is identified. Changing from "break" to "continue" seems like a more intuitive outcome, where all present peaks are mapped and then a warning is raised for each absent peak. I don't really know how to use git so I thought I'd leave this here.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions