Skip to content

Investigate the use of DomainType blanket implementation #15

Open
@adizere

Description

@adizere

Looking at this now and wondering why we need impl DomainType<RawMyType> for <MyType> for many of these. Just the TryFrom/From would be enough. The code compiles and runs fine if we remove all except the cases where RawMyType is not a prost message but wire bytes. For example the client state that is stuffed into an Any type as Vec, or merkle proofs.

(Note - the question is general not only for this PR. We have this pattern everywhere in the code)

Originally posted by @ancazamfir in informalsystems/ibc-rs#391 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions