Skip to content

Commit 00f927a

Browse files
committed
Update versioning and librdkafka repo URL
1 parent 96d7e3d commit 00f927a

8 files changed

+15
-26
lines changed

.gitmodules

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
[submodule "deps/librdkafka"]
22
path = deps/librdkafka
3-
url = https://github.com/edenhill/librdkafka.git
3+
url = https://github.com/confluentinc/librdkafka.git

INTRODUCTION.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
## Configuration
44

5-
You can pass many configuration options to `librdkafka`. A full list can be found in `librdkafka`'s [Configuration.md](https://github.com/edenhill/librdkafka/blob/v2.3.0/CONFIGURATION.md)
5+
You can pass many configuration options to `librdkafka`. A full list can be found in `librdkafka`'s [Configuration.md](https://github.com/confluentinc/librdkafka/blob/v2.3.0/CONFIGURATION.md)
66

77
Configuration keys that have the suffix `_cb` are designated as callbacks. Some
88
of these keys are informational and you can choose to opt-in (for example, `dr_cb`). Others are callbacks designed to
@@ -56,7 +56,7 @@ const producer = new Kafka.Producer({
5656
});
5757
```
5858

59-
A `Producer` requires only `metadata.broker.list` (the Kafka brokers) to be created. The values in this list are separated by commas. For other configuration options, see the [Configuration.md](https://github.com/edenhill/librdkafka/blob/v2.3.0/CONFIGURATION.md) file described previously.
59+
A `Producer` requires only `metadata.broker.list` (the Kafka brokers) to be created. The values in this list are separated by commas. For other configuration options, see the [Configuration.md](https://github.com/confluentinc/librdkafka/blob/v2.3.0/CONFIGURATION.md) file described previously.
6060

6161
The following example illustrates a list with several `librdkafka` options set.
6262

@@ -259,7 +259,7 @@ const consumer = new Kafka.KafkaConsumer({
259259
}, {});
260260
```
261261

262-
The first parameter is the global config, while the second parameter is the topic config that gets applied to all subscribed topics. To view a list of all supported configuration properties, see the [Configuration.md](https://github.com/edenhill/librdkafka/blob/master/CONFIGURATION.md) file described previously. Look for the `C` and `*` keys.
262+
The first parameter is the global config, while the second parameter is the topic config that gets applied to all subscribed topics. To view a list of all supported configuration properties, see the [Configuration.md](https://github.com/confluentinc/librdkafka/blob/master/CONFIGURATION.md) file described previously. Look for the `C` and `*` keys.
263263

264264
The `group.id` and `metadata.broker.list` properties are required for a consumer.
265265

ci/prepublish.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
require('./checks/librdkafka-exists');
22
require('./checks/librdkafka-correct-version');
33
require('./librdkafka-defs-generator.js');
4-
// Temporarily disabled until we move to non-devel versions.
5-
// require('./update-version');
4+
require('./update-version');

ci/update-version.js

+6-16
Original file line numberDiff line numberDiff line change
@@ -84,24 +84,15 @@ function getBranch(cb) {
8484
}
8585

8686
function getPackageVersion(tag, branch) {
87-
const baseVersion = `v${tag.major}.${tag.minor}.${tag.patch}`;
87+
let baseVersion = `v${tag.major}.${tag.minor}.${tag.patch}`;
8888

89-
console.log(`Package version is "${baseVersion}"`);
90-
91-
// never publish with an suffix
92-
// fixes https://github.com/confluentinc/confluent-kafka-javascript/issues/981
93-
// baseVersion += '-';
94-
95-
// if (tag.commit === 0 && branch === 'master') {
96-
// return baseVersion;
97-
// }
9889

99-
// if (branch !== 'master') {
100-
// baseVersion += (tag.commit + 1 + '.' + branch);
101-
// } else {
102-
// baseVersion += (tag.commit + 1);
103-
// }
90+
// publish with a -devel suffix for EA and RC releases.
91+
if (tag.prerelease.length > 0) {
92+
baseVersion += '-' + tag.prerelease.join('-');
93+
}
10494

95+
console.log(`Package version is "${baseVersion}"`);
10596
return baseVersion;
10697
}
10798

@@ -114,7 +105,6 @@ getVersion((err, tag) => {
114105
if (err) {
115106
throw err;
116107
}
117-
118108
pjs.version = getPackageVersion(tag, branch);
119109

120110
fs.writeFileSync(pjsPath, JSON.stringify(pjs, null, 2));

lib/error.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ LibrdKafkaError.wrap = errorWrap;
2121
* Enum for identifying errors reported by the library
2222
*
2323
* You can find this list in the C++ code at
24-
* https://github.com/edenhill/librdkafka/blob/master/src-cpp/rdkafkacpp.h#L148
24+
* https://github.com/confluentinc/librdkafka/blob/master/src-cpp/rdkafkacpp.h#L148
2525
*
2626
* @readonly
2727
* @enum {number}

lib/kafka-consumer.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -655,7 +655,7 @@ KafkaConsumer.prototype.getWatermarkOffsets = function(topic, partition) {
655655
*
656656
* enable.auto.offset.store must be set to false to use this API,
657657
*
658-
* @see https://github.com/edenhill/librdkafka/blob/261371dc0edef4cea9e58a076c8e8aa7dc50d452/src-cpp/rdkafkacpp.h#L1702
658+
* @see https://github.com/confluentinc/librdkafka/blob/261371dc0edef4cea9e58a076c8e8aa7dc50d452/src-cpp/rdkafkacpp.h#L1702
659659
*
660660
* @param {Array.<TopicPartition>} topicPartitions - Topic partitions with offsets to store offsets for.
661661
* @throws {LibrdKafkaError} - Throws when there is no offset stored

lib/topic.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ var topicKeyLength = topicKey.length;
1717
// Take all of the topic special codes from librdkafka and add them
1818
// to the object
1919
// You can find this list in the C++ code at
20-
// https://github.com/edenhill/librdkafka/blob/master/src-cpp/rdkafkacpp.h#L1250
20+
// https://github.com/confluentinc/librdkafka/blob/master/src-cpp/rdkafkacpp.h#L1250
2121
for (var key in librdkafka.topic) {
2222
// Skip it if it doesn't start with ErrorCode
2323
if (key.indexOf('RdKafka::Topic::') !== 0) {

src/connection.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ Baton Connection::GetMetadata(
223223
return Baton(metadata);
224224
} else {
225225
// metadata is not set here
226-
// @see https://github.com/edenhill/librdkafka/blob/master/src-cpp/rdkafkacpp.h#L860
226+
// @see https://github.com/confluentinc/librdkafka/blob/master/src-cpp/rdkafkacpp.h#L860
227227
return Baton(err);
228228
}
229229
}

0 commit comments

Comments
 (0)