Skip to content

Commit 8408e34

Browse files
committed
Pin to pip 9.0.2 for pipenv users only
This addresses an issue raised by @CaseyFeist during code review: Updating pip for pipenv users or requiring them to update without a heads up won't be a good experience (our version is old enough that they'll need to uninstall and reinstall pipenv locally to successfully update). If you can refactor this to stay pinned to current version for pipenv users only, I should be able to accept this (and the related project updates). heroku#833 (comment)
1 parent b4e7ef7 commit 8408e34

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

bin/compile

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,11 @@ for file in "$BUILD_DIR/runtime.txt" "$CACHE_DIR/.heroku/python-version" ; do
7474
esac
7575
done
7676

77+
if [[ -f "$BUILD_DIR/Pipfile" ]]; then
78+
# Do not force pipenv users to re-install pipenv locally.
79+
PIP_UPDATE="9.0.2"
80+
fi
81+
7782
export DEFAULT_PYTHON_STACK PIP_UPDATE
7883
export PY37 PY36 PY35 PY27 PY34
7984

0 commit comments

Comments
 (0)