修复 commonAttributes -- 应该是交集不是并集

Author: xieyuheng

TODO.md

@@ -1,4 +1,4 @@
-修复 `commonAttributes` -- 应该是交集不是并集
+修复 `generateConcepts`
 
 `concept-graph/` -- 从 `generateConcepts` 生成有向图
 

src/context/commonAttributes.test.ts

@@ -19,12 +19,6 @@ test("commonAttributes", () => {
 
   assert.deepStrictEqual(
     commonAttributes(context, ["earth", "mars", "jupiter"]),
-    new Set([
-      "size.small",
-      "size.large",
-      "distance-from-sun.near",
-      "distance-from-sun.far",
-      "moon.yes",
-    ]),
+    new Set(["moon.yes"]),
   )
 })

src/context/commonAttributes.ts

@@ -1,15 +1,27 @@
-import type { Attribute, Context, Entity } from "./index.js"
+import { setIntersection } from "../utils/Set.js"
+import {
+  attributesOf,
+  type Attribute,
+  type Context,
+  type Entity,
+} from "./index.js"
 
 export function commonAttributes(
   context: Context,
   inputEntities: ReadonlySet<Entity> | ReadonlyArray<Entity>,
 ): ReadonlySet<Attribute> {
-  inputEntities = new Set(inputEntities)
+  inputEntities = Array.from(inputEntities)
+  if (inputEntities.length === 0) {
+    return context.attributes
+  }
 
-  const resultAttributes = new Set<Attribute>()
-  for (const inputEntity of inputEntities) {
-    for (const attribute of context.entityAttributeIndex.get(inputEntity) || [])
-      resultAttributes.add(attribute)
+  const [firstEntity, ...restEntities] = inputEntities
+  let resultAttributes = attributesOf(context, firstEntity)
+  for (const entity of restEntities) {
+    resultAttributes = setIntersection(
+      resultAttributes,
+      attributesOf(context, entity),
+    )
   }
 
   return resultAttributes