mongoose 7.18 memory leak MG_TLS_BUILTIN implements

[actg]

The newest version 7.18, by tracking the usage of the calloc and free interfaces, I can confirm that there is indeed a memory leak within the mg_rsa_mod_pow function. I'm not sure why the bi_terminate function was not called and was commented out.

int mg_rsa_mod_pow(const uint8_t *mod, size_t modsz, const uint8_t *exp, size_t expsz, const uint8_t *msg, size_t msgsz, uint8_t *out, size_t outsz) {
	BI_CTX *bi_ctx = bi_initialize();
	bigint *n = bi_import(bi_ctx, mod, (int) modsz);
	bigint *e = bi_import(bi_ctx, exp, (int) expsz);
	bigint *h = bi_import(bi_ctx, msg, (int) msgsz);
	bi_set_mod(bi_ctx, n, 0);
	bigint *m1 = bi_mod_power(bi_ctx, h, e);
	bi_export(bi_ctx, m1, out, (int) outsz);
	bi_free(bi_ctx, n);
	bi_free(bi_ctx, e);
	bi_free(bi_ctx, h);
	bi_free(bi_ctx, m1);
	return 0;
}

• my solution(resolve memory leak)

int mg_rsa_mod_pow(const uint8_t *mod, size_t modsz, const uint8_t *exp, size_t expsz, const uint8_t *msg, size_t msgsz, uint8_t *out, size_t outsz) {
	BI_CTX *bi_ctx = bi_initialize();
	bigint *n = bi_import(bi_ctx, mod, (int) modsz);
	bigint *e = bi_import(bi_ctx, exp, (int) expsz);
	bigint *h = bi_import(bi_ctx, msg, (int) msgsz);
	bi_set_mod(bi_ctx, n, 0);
	bigint *m1 = bi_mod_power(bi_ctx, h, e);
	bi_export(bi_ctx, m1, out, (int) outsz);
	bi_free_mod(bi_ctx,0);
	//bi_free(bi_ctx, n);  // free in bi_free_mod
	//bi_free(bi_ctx, e);  // free in bi_mod_power
	//bi_free(bi_ctx, h);  // free in bi_mod_power
	//bi_free(bi_ctx, m1); // free in bi_export
	bi_terminate(bi_ctx);
	return 0;
}

[scaprile]

#3177
Please stop reopening questions (or issues) for the same subject, your question has already been answered, if there is an actual issue we'll take care of it in due time. If you feel the urge to comment. please do it in the same question. Thank you.