Skip to content

Data Table Support in GraphWidgetType #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Laxenade opened this issue Jul 23, 2024 · 5 comments · Fixed by #638
Closed

Data Table Support in GraphWidgetType #550

Laxenade opened this issue Jul 23, 2024 · 5 comments · Fixed by #638
Labels
feature-request New feature

Comments

@Laxenade
Copy link
Contributor

Feature scope

Custom

Describe your suggested feature

It looks like the data table type is missing from GraphWidgetType. I'm not sure if the data table is a recent widget that CW added or if there hasn't been a use case for it.

cdk-monitoring-constructs/lib/common/widget/types.ts

Lines 9 to 15 in 598dea1

export enum GraphWidgetType {
BAR = "Bar",
LINE = "Line",
PIE = "Pie",
SINGLE_VALUE = "SingleValue",
STACKED_AREA = "StackedArea",
}

It doesn't seem to be too hard to add. I can probably do a PR. I just wanted to confirm the scope first.
@Laxenade Laxenade added the feature-request New feature label Jul 23, 2024
@Laxenade
Copy link
Contributor Author

TableWidget was added in cdk-lib 5 months ago, so it's relatively recent.

aws/aws-cdk@4599aa3

@echeung-amzn
Copy link
Member

Looks like we'd need to bump to minimum aws-cdk-lib@2.128.0 to get TableWidget, but we're currently at min 2.112.0. Bumping that would be a breaking change/major version bump, or temporarily maintaining a copy of it.

I'm not particularly a fan of either right now unless we wanted to bring in other new features from newer aws-cdk-lib versions too. Any thoughts from your end?

@Laxenade
Copy link
Contributor Author

That's fair. I don't have a strong need for it; I was just playing around with different widgets.

@echeung-amzn echeung-amzn added the needs-newer-aws-cdk-lib Requires bumping up our peer dependency. label Aug 23, 2024
@echeung-amzn echeung-amzn removed the needs-newer-aws-cdk-lib Requires bumping up our peer dependency. label Nov 13, 2024
@Laxenade
Copy link
Contributor Author

Now that the dependency on aws-cdk-lib has been bumped, we should be able to do this, right? I can take a stab at making the change; I just want to confirm if there are any other blockers. @echeung-amzn

@echeung-amzn
Copy link
Member

Yes, this should technically be feasible at this point. Feel free to take a stab at it!

@Laxenade Laxenade mentioned this issue Apr 24, 2025
Merged
echeung-amzn pushed a commit that referenced this issue Apr 28, 2025
@Laxenade
feat(widget): add TABLE widget type (#638)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
7b7d081 
Closes #550

Add support for `TableWidget` in dashboards.

---

_By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license_

Co-authored-by: Danny Zhao <zikangz@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(widget): add TABLE widget type Laxenade/cdk-monitoring-constructs
2 participants
@Laxenade @echeung-amzn