Skip to content

Edits to the materials needed for windows users #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
phillybroadbent opened this issue Mar 31, 2025 · 2 comments
Open

Edits to the materials needed for windows users #174

phillybroadbent opened this issue Mar 31, 2025 · 2 comments

Comments

@phillybroadbent
Copy link
Collaborator

On windows I had to add encoding="utf-8" to data_f = open('./eva-data.json', 'r', encoding="utf-8") and data_t = open('./eva-data.csv','w', encoding="utf-8") to run the code without an error

python -m pip freeze > requirements.txt needs to be python.exe -m pip freeze > requirements.txt

@anenadic
Copy link
Collaborator

anenadic commented Mar 31, 2025

There is an issue about encoding: #114. We should really fix this as this is good practice (if you do fix this issue - make sure we propagate the correct code in various branches/rest of the course material).

Not sure about python.exe - just python used to work fine in the past. Perhaps some alias/path setting on your machine @phillybroadbent ?

@smangham
Copy link
Contributor

smangham commented Apr 2, 2025

We discussed this in today's session - it would be great to staple the encoding fix onto the end of the venv section. It's a quick fix but it's a teachable point about platform dependence and implied defaults.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants