multiplayer tutorial crashes with node v22 and v23. Use v21 as workaround OR make a few changes and don't use `-r esm`.

[Henddher]

FYI

I followed the multiplayer tutorial but npm run serve crashes.

I was able to bypass the crash by using node v21 and v20. I didn't try any older version.

---

The crash happens in node itself and only when using v23, and v22. @Thomblin posted the crash in esm but the project was archived on Nov 4th, 2024. It will be appropriate to follow up with node folks and the newly assertion added a few months ago here

❯ npm run serve

> bgio-tutorial@0.1.0 serve
> node -r esm src/server.js

  #  node[89389]: void node::fs::InternalModuleStat(const FunctionCallbackInfo<v8::Value> &) at ../src/node_file.cc:1043
  #  Assertion failed: (args.Length()) >= (2)

----- Native stack trace -----

 1: 0x104906800 node::Assert(node::AssertionInfo const&) [/Users/henddher/.nvm/versions/node/v23.2.0/bin/node]
 2: 0x1066f1444 node::fs::InternalModuleStat(v8::FunctionCallbackInfo<v8::Value> const&) (.cold.3) [/Users/henddher/.nvm/versions/node/v23.2.0/bin/node]
...
48: 0x1048c4dfc node::Start(int, char**) [/Users/henddher/.nvm/versions/node/v23.2.0/bin/node]
49: 0x182853154 start [/usr/lib/dyld]

----- JavaScript stack trace -----

1: /Users/henddher/Documents/github/bgio-tutorial/node_modules/esm/esm.js:1:34535
2: /Users/henddher/Documents/github/bgio-tutorial/node_modules/esm/esm.js:1:34176
...
9: e (/Users/henddher/Documents/github/bgio-tutorial/node_modules/esm/esm.js:1:262673)
10: get (/Users/henddher/Documents/github/bgio-tutorial/node_modules/esm/esm.js:1:262740)

zsh: abort      npm run serve

[Henddher]

If you use nvm:

nvm install 21
nvm use 21
...
npm run serve
npm start

npm start produces this warning right before "Starting the development server". Nonetheless, it all seems to work "ok".

(node:21692) [DEP_WEBPACK_DEVASERVER_ON_AFTER_SETUP_MIDDLEWARE] DeprecationWarning: 'onAfterSetupMiddleware' option is deprecated. Please use the 'setupMiddlewa res' option.
(Use 'node --trace-deprecation"!
..' to show where the warning was created)
(node: 21692) [DEP_WEBPACK_DEVISERVER_ON_BEFORE_SETUP_MIDDLEWARE] DeprecationWarning: 'onBeforeSetupMiddleware' option is deprecated. Please use the 'setupMiddle wares' option.

[Henddher]

After a few minor changes, it all works with node v23.2.0. No need to use --require esm when running the server.

diff --git a/package.json b/package.json
index e16e5cb..5e0e655 100644
--- a/package.json
+++ b/package.json
@@ -18,7 +18,7 @@
     "build": "react-scripts build",
     "test": "react-scripts test",
     "eject": "react-scripts eject",
-    "serve": "node -r esm src/server.js"
+    "serve": "node src/server.js"
   },
   "eslintConfig": {
     "extends": [
diff --git a/src/Game.js b/src/Game.js
index cd503b8..d08fbd7 100644
--- a/src/Game.js
+++ b/src/Game.js
@@ -1,4 +1,4 @@
-import { INVALID_MOVE } from 'boardgame.io/core';
+import { INVALID_MOVE } from 'boardgame.io/dist/esm/core.js';
 
 export const TicTacToe = {
     name: 'tic-tac-toe',
diff --git a/src/server.js b/src/server.js
index c7276bb..3d9f0a0 100644
--- a/src/server.js
+++ b/src/server.js
@@ -1,5 +1,5 @@
-const { Server, Origins } = require('boardgame.io/server');
-const { TicTacToe } = require('./Game');
+import { Server, Origins } from 'boardgame.io/dist/cjs/server.js';
+import { TicTacToe } from './Game.js';
 
 const server = Server({
     games: [TicTacToe],

---

Disclaimer: I'm no a node expert so take these changes with a grain of salt. Especially, the hardcoded dist path changes.

[Thomblin]

Thanks for adding me here @Henddher
So far I am only able to run the server and client using nvm v9 ...

Your patch helped to run the server and actually I am able to run server and client now with the latest version
nvm 23.2.0 and npm 10.9.0

Thank you!

[benbot]

Ah thanks for pointing this out. 🙏
The hardcoded dist paths may be a bit rough. Not sure if those exist before you npm run build.

I've been (slowly 😅 ) working on modernizing boardgame.io and fixing some of this code rot. I'm planning on going full steam on it come january, so i'll update this issue when when -r esm isn't required.

[bbortt]

@benbot let me know if you can use help. would be willing to contribute to an active fork. I've already started my own and took care of migrating to eslint v9, but if someone else is doing stuff I'd be glad to merge changes into it.

some dependencies really need updates because of security stuff.

[benbot]

@bbortt Oh definitely :)

I'll make my fork public once I get all the tests to pass using expressjs instead of koa. Until then it's a little to chaotic to have more than one person poke around with.

I'll let you know here when I do.

[Henddher]

Hi all,

ABOUT THE CRASH

Now that I am running node (22 and 24, (*)), became familiar with exports in package.json node docs, and added it; I was able to revert the hardcoded paths I mentioned above. I'm in the process of validating the solution. Will share details soon but here is the diff in case you want to try it in the meantime. It seems like this solution works. See PR #1227 and boardgame.io react tutorial repo step-by-step showing what changes were required on every step.

• PR Def exports #1227 with package.json "exports": {...} added.

• bgio react tutorial step-by-step https://github.com/Henddher/bgio-react-tutorial/tree/tutorial

NOTE: -r esm is not required.

diff --git a/package.json b/package.json
index d29e7ad..fa7a377 100644
--- a/package.json
+++ b/package.json
@@ -38,6 +38,19 @@
   "main": "dist/boardgameio.js",
   "unpkg": "dist/boardgameio.min.js",
   "module": "dist/boardgameio.es.js",
+  "exports": {
+    ".": {
+      "require": "./dist/boardgameio.js",
+      "import": "./dist/boardgameio.es.js"
+    },
+    "./server": {
+      "import": "./dist/cjs/server.js"
+    },
+    "./*": {
+      "require": "./dist/cjs/*.js",
+      "import": "./dist/esm/*.js"
+    }
+  },
   "types": "dist/types/src/types.d.ts",
   "files": [
     "src",
@@ -208,4 +221,4 @@
       "pre-push": "npm run test:coverage"
     }
   }

(*) Older versions didn't work and/or are unsupported on my mac (m2 arm64)

---

UPDATE RE: KOA->EXPRESS

I am close to getting the code fully migrated out from koa onto express 5. ATM, all tests are passing but I'm fighting what I hope to be the last issue: client[socket.io-client] -> server[socket.io]).

I managed to fully migrate from koa to express successfully. There are only 2 cors related test failures that according to my analysis are indeed false positive.

#1226

@bbortt, would you like to colab?

---