Description
Description of the feature request:
Background
When --worker_verbose is set, a regular work request will have its verbosity set to 10. This can be seen here: https://github.com/bazelbuild/bazel/blob/master/src/main/java/com/google/devtools/build/lib/worker/WorkerSpawnRunner.java#L278-L280
When a cancel request is made the verbosity is not set, regardless of --worker_verbose. This can be seen here: https://github.com/bazelbuild/bazel/blob/master/src/main/java/com/google/devtools/build/lib/worker/WorkerSpawnRunner.java#L629-L633
I realized this is expected after reading the documentation:
A cancel request is a WorkRequest with the cancel field set (and similarly a cancel response is a WorkResponse with the was_cancelled field set). The only other field that must be in a cancel request or cancel response is request_id, indicating which request to cancel.
From: https://bazel.build/remote/creating#cancellation
Proposal
I, with my limited knowledge of this area, propose that verbosity be set on both regular and cancellation work requests.
We have workers for which we use --worker_verbose to enable verbose logging for debugging purposes. Currently, I'm not aware of a good way to enable that verbose logging for cancel requests.
If folks are on board, I'm happy to make the change. If folks are not on board, and this will cause some sort of issue, then no worries.
Which category does this issue belong to?
Remote Execution
What underlying problem are you trying to solve with this feature?
Provide a way to enable verbose logging for cancel requests received by workers.
Which operating system are you running Bazel on?
Ubuntu 24.04
What is the output of bazel info release?
release 8.2.0rc2
If bazel info release returns development version or (@non-git), tell us how you built Bazel.
No response
What's the output of git remote get-url origin; git rev-parse HEAD ?
[email protected]:bazelbuild/bazel.git
22c782ded3a90558661f9c6474bd1dd5ef7c1e42
Have you found anything relevant by searching the web?
No response
Any other information, logs, or outputs that you want to share?
No response