File tree Expand file tree Collapse file tree 1 file changed +5
-7
lines changed
src/main/java/com/google/devtools/build/lib/remote Expand file tree Collapse file tree 1 file changed +5
-7
lines changed Original file line number Diff line number Diff line change @@ -624,16 +624,14 @@ private void finalizeDownload(
624
624
// parent directory after prefetching.
625
625
directoryTracker .setTemporarilyWritable (parentDir );
626
626
} else {
627
- // There are three cases :
627
+ // One of the following must apply :
628
628
// (1) The file does not belong to a tree artifact.
629
629
// (2) The file belongs to a tree artifact created by an action template expansion.
630
- // (3) The file belongs to a tree artifact but we don't know it. This can occur when the
631
- // file belongs to a tree artifact inside a fileset (see b/254844173).
632
630
// In case (1), the parent directory is a package or a subdirectory of a package, and should
633
- // remain writable. In cases (2) and (3) , even though we arguably ought to set the output
634
- // permissions on the parent directory to match the outcome of a locally executed action, we
635
- // choose not to do it and avoid the additional implementation complexity required to detect a
636
- // race condition between concurrent calls touching the same directory.
631
+ // remain writable. In case (2), even though we arguably ought to set the output permissions
632
+ // on the parent directory to match local execution, we choose not to do it and avoid the
633
+ // additional implementation complexity required to detect a race condition between concurrent
634
+ // calls touching the same directory.
637
635
directoryTracker .setPermanentlyWritable (parentDir );
638
636
}
639
637
You can’t perform that action at this time.
0 commit comments