Skip to content

Commit e953910

Browse files
tjgqcopybara-github
authored andcommitted
Fix outdated comment.
After 9363249 filesets now carry proper artifacts. PiperOrigin-RevId: 760583341 Change-Id: I391321edb94cfd1396de203e64c2782c3118cde5
1 parent 9f49ded commit e953910

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

src/main/java/com/google/devtools/build/lib/remote/AbstractActionInputPrefetcher.java

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -624,16 +624,14 @@ private void finalizeDownload(
624624
// parent directory after prefetching.
625625
directoryTracker.setTemporarilyWritable(parentDir);
626626
} else {
627-
// There are three cases:
627+
// One of the following must apply:
628628
// (1) The file does not belong to a tree artifact.
629629
// (2) The file belongs to a tree artifact created by an action template expansion.
630-
// (3) The file belongs to a tree artifact but we don't know it. This can occur when the
631-
// file belongs to a tree artifact inside a fileset (see b/254844173).
632630
// In case (1), the parent directory is a package or a subdirectory of a package, and should
633-
// remain writable. In cases (2) and (3), even though we arguably ought to set the output
634-
// permissions on the parent directory to match the outcome of a locally executed action, we
635-
// choose not to do it and avoid the additional implementation complexity required to detect a
636-
// race condition between concurrent calls touching the same directory.
631+
// remain writable. In case (2), even though we arguably ought to set the output permissions
632+
// on the parent directory to match local execution, we choose not to do it and avoid the
633+
// additional implementation complexity required to detect a race condition between concurrent
634+
// calls touching the same directory.
637635
directoryTracker.setPermanentlyWritable(parentDir);
638636
}
639637

0 commit comments

Comments
 (0)