Skip to content

Commit 7f5c408

Browse files
committed
[BABEL-4673] Disable CREATE VIEW ON stmt with PIVOT
Disable CREATE VIEW ON stmt with PIVOT operator due to pg_dump cannot dump pivot view with correct dependency and newly added fields in FuncExpr casued readFunc failed to parse previous minor version string parsetree during select from view after mVU. Task: BABEL-4673 Signed-off-by: Yanjie Xu <[email protected]>
1 parent 1376fa8 commit 7f5c408

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/include/fmgr.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ typedef struct FunctionCallInfoBaseData
9494
short nargs; /* # arguments actually passed */
9595
List *pivot_parsetree; /* bbf_pivot function required rewritted parsetrees */
9696
List *pivot_extrainfo; /* bbf_pivot function required aggregation function and source sql string */
97-
#define FIELDNO_FUNCTIONCALLINFODATA_ARGS 6
97+
#define FIELDNO_FUNCTIONCALLINFODATA_ARGS 8
9898
NullableDatum args[FLEXIBLE_ARRAY_MEMBER];
9999
} FunctionCallInfoBaseData;
100100

src/include/nodes/primnodes.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -696,9 +696,9 @@ typedef struct FuncExpr
696696
/* token location, or -1 if unknown */
697697
int location;
698698
/* bbf_pivot function required rewritted parsetrees */
699-
List *pivot_parsetree pg_node_attr(query_jumble_ignore);
699+
List *pivot_parsetree pg_node_attr(query_jumble_ignore, read_write_ignore, read_as(NULL));
700700
/* bbf_pivot function required aggregation function name and source sql string */
701-
List *pivot_extrainfo pg_node_attr(query_jumble_ignore);
701+
List *pivot_extrainfo pg_node_attr(query_jumble_ignore, read_write_ignore, read_as(NULL));
702702
} FuncExpr;
703703

704704
/*

0 commit comments

Comments
 (0)