How DynamoDB client get different retries number in LEGACY retry mode?

[QiuHongHao123]

As the doc describe, DynamoDB will have up to 8 times retry in LEGACY mode.
But when we build a RetryPolicy and overwrite the DynamoDB client config. I found that numRetries only get from SdkDefaultRetrySetting and always be set up as 4.
So is it a bug issue? Or we have some magical mechanism to guarantee DynamoDB client can get the correct retry number?

private BuilderImpl(RetryMode retryMode) { this.retryMode = retryMode; this.numRetries = SdkDefaultRetrySetting.maxAttempts(retryMode) - 1; this.additionalRetryConditionsAllowed = true; this.backoffStrategy = BackoffStrategy.defaultStrategy(retryMode); this.throttlingBackoffStrategy = BackoffStrategy.defaultThrottlingStrategy(retryMode); this.retryCondition = RetryCondition.defaultRetryCondition(); this.retryCapacityCondition = TokenBucketRetryCondition.forRetryMode(retryMode); }

`
public static Integer maxAttempts(RetryMode retryMode) {
Integer maxAttempts = SdkSystemSetting.AWS_MAX_ATTEMPTS.getIntegerValue().orElse(null);

    if (maxAttempts == null) {
        switch (retryMode) {
            case LEGACY:
                maxAttempts = Legacy.MAX_ATTEMPTS;
                break;
            case ADAPTIVE:
            case STANDARD:
                maxAttempts = Standard.MAX_ATTEMPTS;
                break;
            default:
                throw new IllegalStateException("Unsupported RetryMode: " + retryMode);
        }
    }

`

[QiuHongHao123]

It seem have format problem in problem description.

public static final RetryPolicy SDK_LEGACY_RETRY_POLICY = RetryPolicy.builder(RetryMode.LEGACY)
            .build();

DynamoDbClient dynamoDbClient = DynamoDbClient.builder()
                .credentialsProvider(credentials.get())
                .overrideConfiguration(ClientOverrideConfiguration.builder()
                        .retryPolicy(SDK_LEGACY_RETRY_POLICY)
                        .build())
                .region(awsRegionProvider.getRegion())
                .build();

RetryPolicy

 private BuilderImpl(RetryMode retryMode) {
            this.retryMode = retryMode;
            this.numRetries = SdkDefaultRetrySetting.maxAttempts(retryMode) - 1;
            this.additionalRetryConditionsAllowed = true;
            this.backoffStrategy = BackoffStrategy.defaultStrategy(retryMode);
            this.throttlingBackoffStrategy = BackoffStrategy.defaultThrottlingStrategy(retryMode);
            this.retryCondition = RetryCondition.defaultRetryCondition();
            this.retryCapacityCondition = TokenBucketRetryCondition.forRetryMode(retryMode);
        }

SdkDefaultRetrySetting

public static Integer maxAttempts(RetryMode retryMode) {
        Integer maxAttempts = SdkSystemSetting.AWS_MAX_ATTEMPTS.getIntegerValue().orElse(null);

        if (maxAttempts == null) {
            switch (retryMode) {
                case LEGACY:
                    maxAttempts = Legacy.MAX_ATTEMPTS;
                    break;
                case ADAPTIVE:
                case STANDARD:
                    maxAttempts = Standard.MAX_ATTEMPTS;
                    break;
                default:
                    throw new IllegalStateException("Unsupported RetryMode: " + retryMode);
            }
        }