feat(synthetics): add 5.0 and 5.1 python canary runtimes #34254
+1,548
−601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
beginning-contributor
github-actions
bot
added
feature-request
aws-cdk-automation
requested changes
Apr 25, 2025
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Features must contain a change to a README file.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
✅ A exemption request has been requested. Please wait for a maintainer's review.
|
Exemption Request: I think updating the README is unnecessary, as this only involves adding values to an enum. |
aws-cdk-automation
added
the
pr-linter/exemption-requested
|
Can someone check the integration tests snap shot generation? Right now those are failing and not generating the updated snapshots. this is what I am doing Bellow is the output of my two attempts: Attempt # 1: Error: "Could not unzip uploaded file. Please check your file, then try to upload again" -> Stack destroy failed due to some files in s3 bucket which I manually removed and destroyed the stack Attempt # 2: Stack rolled back and no snapshots are generated |
armujahid
commented
Apr 25, 2025
2 tasks
github-actions
bot
added
the
effort/small
badmintoncryer
suggested changes
Apr 25, 2025
There was a problem hiding this comment.
I'm not sure if this will solve the fundamental issue, but could you please re-run the integ test following these steps?
- Merge the newest
origin/main - Run
yarnat the repository root - Run
npx lerna run build --scope=@aws-cdk-testing/framework-integ --skip-nx-cache - Delete the
integ.canary.js.snapshotfolder - Run the integ test
armujahid
force-pushed
the
34252-add-missing-canary-runtimes
branch
from
1c88d8e to
5680c84
Compare
|
@badmintoncryer I did what you mentioned but this doesn't resolve the issue.
|
…n tests Not sure why that is failing but this apparently has nothing to do with my changes.
armujahid
commented
Apr 25, 2025
| @@ -68,20 +68,6 @@ const folderAsset = new Canary(stack, 'FolderAsset', { | |||
| cleanup: Cleanup.LAMBDA, | |||
| }); | |||
|
|
|||
| const zipAsset = new Canary(stack, 'ZipAsset', { | |||
There was a problem hiding this comment.
this ZipAsset canary is causing integration test failure that apparently has nothing to do with my changes. integration tests pass after removing this
yarn run v1.22.22
$ integ-runner --language javascript test/aws-synthetics/test/integ.canary.js --update-on-failed
Verifying integration test snapshots...
NEW aws-synthetics/test/integ.canary 0.58s
Snapshot Results:
Tests: 1 failed, 1 total
Failed: /home/arm/repos/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-synthetics/test/integ.canary.js
Running integration tests for failed tests...
Running in parallel across regions: us-east-1, us-east-2, us-west-2
Running test /home/arm/repos/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-synthetics/test/integ.canary.js in us-east-1
SUCCESS aws-synthetics/test/integ.canary-IntegCanaryTest/DefaultTest 375.46s
AssertionResultsAwsApiCallSyntheticsgetCanaryRuns63fe71cb09fa7431b889f8bf43ee777d - success
AssertionResultsAwsApiCallSyntheticsgetCanaryRuns7529a951b35a7be38dbb382fdb631be1 - success
AssertionResultsAwsApiCallSyntheticsgetCanaryRuns4b48cf669b28df275fb8f9ab27c9d17e - success
AssertionResultsAwsApiCallSyntheticsgetCanaryRunsf99e1fdf6a0501dc2db966a65404911a - success
AssertionResultsAwsApiCallSyntheticsgetCanaryRuns21e8ff765a0e5e2ac57390c6859b307a - success
AssertionResultsAwsApiCallSyntheticsgetCanaryRunsef29924a26a142cf4802d3aeba9f98dd - success
AssertionResultsAwsApiCallSyntheticsgetCanaryRuns588dd7080086c213b18ceae14d834792 - success
AssertionResultsAwsApiCallSyntheticsgetCanaryRunsca5188fa640c2dd7572e59b0dea5a8a7 - success
AssertionResultsAwsApiCallSyntheticsgetCanaryRunsf91ed1876add8c22a7b35f8a7e752983 - success
AssertionResultsAwsApiCallSyntheticsgetCanaryRuns5d388f635365b7bc00ae6d5b493ca583 - success
AssertionResultsAwsApiCallSyntheticsgetCanaryRunsa8dd9b1d9ab4940791dfca7840ef18a1 - success
AssertionResultsAwsApiCallSyntheticsgetCanaryRuns73affc294cec6ea5bf16e36993db617f - success
AssertionResultsAwsApiCallSyntheticsgetCanaryRuns10023df2885f280da73de72d07b27d46 - success
AssertionResultsAwsApiCallSyntheticsgetCanaryRuns072a1d4866ac44cd80d65b9fb7140f44 - success
AssertionResultsAwsApiCallSyntheticsgetCanaryRuns5d4a076a2d1bdce1061eefc55660bf8b - success
AssertionResultsAwsApiCallSyntheticsgetCanaryRunsfdf70d7c918d67340f0ac4c6d270caa3 - success
AssertionResultsAwsApiCallSyntheticsgetCanaryRunsb217581b3c2b9adcdbff5018eb672c9c - success
Test Results:
Tests: 1 passed, 1 total
Done in 376.49s.
Not sure how to fix this. Any idea?
armujahid
changed the title
|
@armujahid I've executed your integ test including zip asset in my repository. yarn integ test/aws-synthetics/test/integ.canary.js --update-on-failed
yarn run v1.22.21
$ integ-runner --language javascript test/aws-synthetics/test/integ.canary.js --update-on-failed
Verifying integration test snapshots...
NEW aws-synthetics/test/integ.canary 2.461s
Snapshot Results:
Tests: 1 failed, 1 total
Failed: /Users/kazuhoshinozuka/git/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-synthetics/test/integ.canary.js
Running integration tests for failed tests...
Running in parallel across regions: us-east-1, us-east-2, us-west-2
Running test /Users/kazuhoshinozuka/git/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-synthetics/test/integ.canary.js in us-east-1
SUCCESS aws-synthetics/test/integ.canary-IntegCanaryTest/DefaultTest 392.042s
AssertionResultsAwsApiCallSyntheticsgetCanaryRuns63fe71cb09fa7431b889f8bf43ee777d - success
AssertionResultsAwsApiCallSyntheticsgetCanaryRuns7529a951b35a7be38dbb382fdb631be1 - success
AssertionResultsAwsApiCallSyntheticsgetCanaryRuns4b48cf669b28df275fb8f9ab27c9d17e - success
AssertionResultsAwsApiCallSyntheticsgetCanaryRunsf99e1fdf6a0501dc2db966a65404911a - success
AssertionResultsAwsApiCallSyntheticsgetCanaryRuns21e8ff765a0e5e2ac57390c6859b307a - success
AssertionResultsAwsApiCallSyntheticsgetCanaryRunsef29924a26a142cf4802d3aeba9f98dd - success
AssertionResultsAwsApiCallSyntheticsgetCanaryRuns588dd7080086c213b18ceae14d834792 - success
AssertionResultsAwsApiCallSyntheticsgetCanaryRunsaf0432d0aeabb461c9a56a62dba7b6fe - success
AssertionResultsAwsApiCallSyntheticsgetCanaryRunsca5188fa640c2dd7572e59b0dea5a8a7 - success
AssertionResultsAwsApiCallSyntheticsgetCanaryRunsf91ed1876add8c22a7b35f8a7e752983 - success
AssertionResultsAwsApiCallSyntheticsgetCanaryRuns5d388f635365b7bc00ae6d5b493ca583 - success
AssertionResultsAwsApiCallSyntheticsgetCanaryRunsa8dd9b1d9ab4940791dfca7840ef18a1 - success
AssertionResultsAwsApiCallSyntheticsgetCanaryRuns73affc294cec6ea5bf16e36993db617f - success
AssertionResultsAwsApiCallSyntheticsgetCanaryRuns10023df2885f280da73de72d07b27d46 - success
AssertionResultsAwsApiCallSyntheticsgetCanaryRuns072a1d4866ac44cd80d65b9fb7140f44 - success
AssertionResultsAwsApiCallSyntheticsgetCanaryRuns5d4a076a2d1bdce1061eefc55660bf8b - success
AssertionResultsAwsApiCallSyntheticsgetCanaryRunsfdf70d7c918d67340f0ac4c6d270caa3 - success
AssertionResultsAwsApiCallSyntheticsgetCanaryRunsb217581b3c2b9adcdbff5018eb672c9c - success
Test Results:
Tests: 1 passed, 1 total
✨ Done in 395.45s.Could you please pull the snapshot file from my repo? |
|
@badmintoncryer done. I have pulled your commit from your branch. |
badmintoncryer
approved these changes
Apr 26, 2025
badmintoncryer
approved these changes
Apr 26, 2025
|
@badmintoncryer thanks. I am curious how did snapshot generation work with that zip asset? |
|
@armujahid I've only done following steps... Could you please merge main branch again? It results |
|
@badmintoncryer that's weird. Not sure why those steps didn't work for me when I tried. I used node.js latest LTS v22.15.0 with latest yarn and my OS is Manjaro. May be we can add a dockerized build and integration test execution command that is guaranteed to work everywhere. Sure, let me merge main again. |
|
@badmintoncryer my branch is already synced with main. There is nothing more that can be merged from main. |
|
@armujahid When a new commit is added to main, please handle it! |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
the
pr/needs-maintainer-review
|
@badmintoncryer done. But that label is still not attached. |
|
@armujahid It seems to be attached! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #34252
Reason for this change
Description of changes
add SYNTHETICS_PYTHON_SELENIUM_5_0 and SYNTHETICS_PYTHON_SELENIUM_5_1
https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Library_python_selenium.html
Description of how you validated changes
Unit tests (passing):
Integration tests (failing with "Could not unzip uploaded file. Please check your file, then try to upload again" and snapshots aren't generating for me to commit):
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license