aws_route53: delete_existing is creating and deleting 2x #34230
Labels
Comments
BwL1289
added
bug
|
appears to be related to #26754 |
|
Hey @BwL1289, thank you for reporting this issue and providing us the logs. On diving into this issue, I was able to observe the following when reproducing this issue. CDK versions Reproduction Steps:
export class Route53IssueStack extends cdk.Stack {
constructor(scope: Construct, id: string, props?: cdk.StackProps) {
super(scope, id, props);
// Step 1: Create a VPC
const vpc = new ec2.Vpc(this, 'VPC', {
maxAzs: 2,
natGateways: 0,
});
// Step 1: Create an ALB
const alb = new elbv2.ApplicationLoadBalancer(this, 'ALB', {
vpc,
internetFacing: true,
});
// Create a hosted zone
const hostedZone = new route53.PublicHostedZone(this, 'HostedZone', {
zoneName: 'mydemo-domain.net',
});
// Create an A record
new route53.ARecord(this, 'ARecord', {
zone: hostedZone,
recordName: 'api.dev.mydemo-domain.net',
target: route53.RecordTarget.fromAlias(
new targets.LoadBalancerTarget(alb)
),
deleteExisting: true,
});
// Add HTTP listener
alb.addListener('HttpListener', {
port: 80,
protocol: elbv2.ApplicationProtocol.HTTP,
defaultAction: elbv2.ListenerAction.fixedResponse(200, {
contentType: 'text/plain',
messageBody: 'OK',
}),
});
}
}
// Create a hosted zone
const hostedZone = new route53.PublicHostedZone(this, 'HostedZone', {
zoneName: 'mydemo-domain-abc.net',
});
// Create an A record
new route53.ARecord(this, 'ARecord', {
zone: hostedZone,
recordName: 'api.dev.mydemo-domain-abc.net',
target: route53.RecordTarget.fromAlias(
new targets.LoadBalancerTarget(alb)
),
deleteExisting: true,
});
HostedZoneDB99F866:
Type: AWS::Route53::HostedZone
Properties:
Name: mydemo-domain.net. # Should be mydemo-domain-abc.net.
Marking this as P1 |
ykethan
added
p1
and removed
needs-triage
|
@ykethan thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
It's possible there's some user error in here.
When
delete_existing=True, and something goes awry from another resource related to the A record (see below for reproduction steps), I am seeing the custom resource run twice so the a record gets created, then deleted, then created, and then finally deleted so by the time the stack finishes updating, there's no A record at all.Here are the logs:
Regression Issue
Last Known Working CDK Version
No response
Expected Behavior
The existing a record gets deleted and then created with the new value.
Current Behavior
By the time the stack finishes updating, there's no A record at all.
Reproduction Steps
• An A record with
delete_existing=True• An ALB w/
protocol=lb.ApplicationProtocol.HTTPprotocol=lb.ApplicationProtocol.HTTPSwhich may requiredomain_nameanddomain_zoneto be set. In my case there was a mistake in here somewhere, and thedomain_namegot set to some other value (i.e. original value wasapi.dev.example.coman the newdomain_namegets set to justdev.example.com), the A record was deleted and recreated with the new record name.Possible Solution
Detect if the a record has already been deleted and (re)created by the custom resource and if so, don't run the CR again.
Additional Information/Context
No response
CDK CLI Version
2.1000.3 (build 321a46a)
Framework Version
No response
Node.js Version
v22.12.0
OS
Mac
Language
Python
Language Version
No response
Other information
No response
The text was updated successfully, but these errors were encountered: