-
Notifications
You must be signed in to change notification settings - Fork 28
API key not configurable #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Yeah, it's not ideal that the API key is within the source. I made it this way in order to keep the implementation as simple as possible. I think putting the API as a |
I'd love to work on this! And you took the words right out of my mouth! That said, forcing a token to be part of the HTML could make them easy to steal, and it could make a users existing JS token system harder to use (if that system assumes you'll be passing variables to JavaScript.). |
Hmmm.... looking into the name shouts API, it seems like the only way to keep the key a secret is to send the request on the server. |
Yeah, maybe we're better off just keeping it the way it is w/ one universal API key? Let me know if you have any other ideas. Thanks for looking into it! |
After a quick scan of the minified code and the documentation, I don't seen any way to change the NameShouts API key without changing the source. Should this be a
<meta>
(to continue with the pure markup theme of the API) or should it be part of a new API (e.g.new Vocalizer(apiKey)
)?The text was updated successfully, but these errors were encountered: