added checks to param object tests to verify that all positions in the meshes are defined

Author: frederic-schwarz

test/scene/structure/parametric-objects/closet.js

@@ -1,5 +1,6 @@
-import applyDefaults from '../../../../src/scene/structure/apply-defaults.js';
+import applyDefaults from '../../../../src/scene/structure/apply-defaults.js'
 import closet from '../../../../src/scene/structure/parametric-objects/closet'
+import { isNaN } from 'lodash'
 
 // mock runtime module to prevent from tests blowing up
 jest.mock('../../../../src/core/runtime.js', () => ({isBrowser: false, isNode: true}))
@@ -12,4 +13,7 @@ test('get closet data3d', async function() {
   expect(Object.keys(data3d.meshes)).toEqual([ 'closet' ])
   expect(data3d.meshes.closet.positions).toBeDefined()
   expect(data3d.meshes.closet.uvs).toBeDefined()
+
+  // check for valid vertices
+  expect(data3d.meshes.closet.positions.every(a => !isNaN(a))).toBeTruthy()
 });

test/scene/structure/parametric-objects/column.js

@@ -1,5 +1,6 @@
-import applyDefaults from '../../../../src/scene/structure/apply-defaults.js';
+import applyDefaults from '../../../../src/scene/structure/apply-defaults.js'
 import column from '../../../../src/scene/structure/parametric-objects/column'
+import { isNaN } from 'lodash'
 
 // mock runtime module to prevent from tests blowing up
 jest.mock('../../../../src/core/runtime.js', () => ({isBrowser: false, isNode: true}))
@@ -10,7 +11,14 @@ test('get column data3d', async function() {
 
   // mesh names
   expect(Object.keys(data3d.meshes)).toEqual([ 'top', 'sides', 'bottom' ])
+  expect(data3d.meshes.top.positions).toBeDefined()
+  expect(data3d.meshes.top.uvs).toBeDefined()
+  expect(data3d.meshes.top.normals).toBeDefined()
   expect(data3d.meshes.sides.positions).toBeDefined()
   expect(data3d.meshes.sides.uvs).toBeDefined()
   expect(data3d.meshes.sides.normals).toBeDefined()
+
+  // check for valid vertices
+  expect(data3d.meshes.top.positions.every(a => !isNaN(a))).toBeTruthy()
+  expect(data3d.meshes.sides.positions.every(a => !isNaN(a))).toBeTruthy()
 });

test/scene/structure/parametric-objects/door.js

@@ -1,5 +1,6 @@
-import applyDefaults from '../../../../src/scene/structure/apply-defaults.js';
+import applyDefaults from '../../../../src/scene/structure/apply-defaults.js'
 import door from '../../../../src/scene/structure/parametric-objects/door'
+import { isNaN } from 'lodash'
 
 // mock runtime module to prevent from tests blowing up
 jest.mock('../../../../src/core/runtime.js', () => ({isBrowser: false, isNode: true}))
@@ -12,4 +13,13 @@ test('get door data3d', async function() {
   expect(Object.keys(data3d.meshes)).toEqual(['frame', 'handle', 'leaf', 'threshold'])
   expect(data3d.meshes.frame.positions).toBeDefined()
   expect(data3d.meshes.frame.normals).toBeDefined()
+  expect(data3d.meshes.handle.positions).toBeDefined()
+  expect(data3d.meshes.handle.normals).toBeDefined()
+  expect(data3d.meshes.leaf.positions).toBeDefined()
+  expect(data3d.meshes.leaf.normals).toBeDefined()
+
+  // check for valid vertices
+  expect(data3d.meshes.frame.positions.every(a => !isNaN(a))).toBeTruthy()
+  expect(data3d.meshes.handle.positions.every(a => !isNaN(a))).toBeTruthy()
+  expect(data3d.meshes.leaf.positions.every(a => !isNaN(a))).toBeTruthy()
 });

test/scene/structure/parametric-objects/floor.js

@@ -1,5 +1,6 @@
-import applyDefaults from '../../../../src/scene/structure/apply-defaults.js';
+import applyDefaults from '../../../../src/scene/structure/apply-defaults.js'
 import floor from '../../../../src/scene/structure/parametric-objects/floor'
+import { isNaN } from 'lodash'
 
 // mock runtime module to prevent from tests blowing up
 jest.mock('../../../../src/core/runtime.js', () => ({isBrowser: false, isNode: true, require: require}))
@@ -13,4 +14,8 @@ test('get floor data3d', async function() {
   expect(data3d.meshes.top.positions).toBeDefined()
   expect(data3d.meshes.top.uvs).toBeDefined()
   expect(data3d.meshes.top.normals).toBeDefined()
+  // check for valid vertices
+  expect(data3d.meshes.top.positions.every(a => !isNaN(a))).toBeTruthy()
+  expect(data3d.meshes.sides.positions.every(a => !isNaN(a))).toBeTruthy()
+  expect(data3d.meshes.ceiling.positions.every(a => !isNaN(a))).toBeTruthy()
 });

test/scene/structure/parametric-objects/kitchen.js

@@ -1,5 +1,6 @@
-import applyDefaults from '../../../../src/scene/structure/apply-defaults.js';
+import applyDefaults from '../../../../src/scene/structure/apply-defaults.js'
 import kitchen from '../../../../src/scene/structure/parametric-objects/kitchen'
+import { isNaN } from 'lodash'
 
 // mock runtime module to prevent from tests blowing up
 jest.mock('../../../../src/core/runtime.js', () => ({isBrowser: false, isNode: true, require: require }))
@@ -12,4 +13,11 @@ test('get kitchen data3d', async function() {
   expect(Object.keys(data3d.meshes)).toEqual(['sink_0', 'kitchen', 'counter', 'oven', 'cooktop', 'extractor', 'microwave'])
   expect(data3d.meshes.kitchen.positions).toBeDefined()
   expect(data3d.meshes.kitchen.uvs).toBeDefined()
+  // check for valid vertices
+  expect(data3d.meshes.sink_0.positions.every(a => !isNaN(a))).toBeTruthy()
+  expect(data3d.meshes.kitchen.positions.every(a => !isNaN(a))).toBeTruthy()
+  expect(data3d.meshes.counter.positions.every(a => !isNaN(a))).toBeTruthy()
+  expect(data3d.meshes.oven.positions.every(a => !isNaN(a))).toBeTruthy()
+  expect(data3d.meshes.cooktop.positions.every(a => !isNaN(a))).toBeTruthy()
+  expect(data3d.meshes.extractor.positions.every(a => !isNaN(a))).toBeTruthy()
 });

test/scene/structure/parametric-objects/polyfloor.js

@@ -1,5 +1,6 @@
-import applyDefaults from '../../../../src/scene/structure/apply-defaults.js';
+import applyDefaults from '../../../../src/scene/structure/apply-defaults.js'
 import polyfloor from '../../../../src/scene/structure/parametric-objects/polyfloor'
+import { isNaN } from 'lodash'
 
 // mock runtime module to prevent from tests blowing up
 jest.mock('../../../../src/core/runtime.js', () => ({isBrowser: false, isNode: true}))
@@ -13,4 +14,8 @@ test('get polyfloor data3d', async function() {
   expect(data3d.meshes.top.positions).toBeDefined()
   expect(data3d.meshes.top.uvs).toBeDefined()
   expect(data3d.meshes.top.normals).toBeDefined()
+  // check for valid vertices
+  expect(data3d.meshes.top.positions.every(a => !isNaN(a))).toBeTruthy()
+  expect(data3d.meshes.sides.positions.every(a => !isNaN(a))).toBeTruthy()
+  expect(data3d.meshes.ceiling.positions.every(a => !isNaN(a))).toBeTruthy()
 });

test/scene/structure/parametric-objects/railing.js

@@ -1,5 +1,6 @@
-import applyDefaults from '../../../../src/scene/structure/apply-defaults.js';
+import applyDefaults from '../../../../src/scene/structure/apply-defaults.js'
 import railing from '../../../../src/scene/structure/parametric-objects/railing'
+import { isNaN } from 'lodash'
 
 // mock runtime module to prevent from tests blowing up
 jest.mock('../../../../src/core/runtime.js', () => ({isBrowser: false, isNode: true, require: require}))
@@ -11,4 +12,6 @@ test('get railing data3d', async function() {
   // mesh names
   expect(Object.keys(data3d.meshes)).toEqual([ 'railing' ])
   expect(data3d.meshes.railing.positions).toBeDefined()
+  // check for valid vertices
+  expect(data3d.meshes.railing.positions.every(a => !isNaN(a))).toBeTruthy()
 });

test/scene/structure/parametric-objects/stairs.js

@@ -1,5 +1,6 @@
-import applyDefaults from '../../../../src/scene/structure/apply-defaults.js';
+import applyDefaults from '../../../../src/scene/structure/apply-defaults.js'
 import stairs from '../../../../src/scene/structure/parametric-objects/stairs'
+import { isNaN } from 'lodash'
 
 // mock runtime module to prevent from tests blowing up
 jest.mock('../../../../src/core/runtime.js', () => ({isBrowser: false, isNode: true}))
@@ -12,4 +13,8 @@ test('get stairs data3d', async function() {
   expect(Object.keys(data3d.meshes)).toEqual([ 'steps', 'tread', 'railing' ])
   expect(data3d.meshes.steps.positions).toBeDefined()
   expect(data3d.meshes.steps.uvs).toBeDefined()
+  // check for valid vertices
+  expect(data3d.meshes.steps.positions.every(a => !isNaN(a))).toBeTruthy()
+  expect(data3d.meshes.tread.positions.every(a => !isNaN(a))).toBeTruthy()
+  expect(data3d.meshes.railing.positions.every(a => !isNaN(a))).toBeTruthy()
 });

test/scene/structure/parametric-objects/wall.js

@@ -1,5 +1,6 @@
-import applyDefaults from '../../../../src/scene/structure/apply-defaults.js';
+import applyDefaults from '../../../../src/scene/structure/apply-defaults.js'
 import wall from '../../../../src/scene/structure/parametric-objects/wall'
+import { isNaN } from 'lodash'
 
 // mock runtime module to prevent from tests blowing up
 jest.mock('../../../../src/core/runtime.js', () => ({isBrowser: false, isNode: true, require: require}))
@@ -13,4 +14,9 @@ test('get wall data3d', async function() {
   expect(data3d.meshes.front.positions).toBeDefined()
   expect(data3d.meshes.front.uvs).toBeDefined()
   expect(data3d.meshes.front.normals).toBeDefined()
+  // check for valid vertices
+  expect(data3d.meshes.front.positions.every(a => !isNaN(a))).toBeTruthy()
+  expect(data3d.meshes.back.positions.every(a => !isNaN(a))).toBeTruthy()
+  expect(data3d.meshes.top.positions.every(a => !isNaN(a))).toBeTruthy()
+  expect(data3d.meshes.base.positions.every(a => !isNaN(a))).toBeTruthy()
 });

test/scene/structure/parametric-objects/window.js

@@ -1,5 +1,6 @@
 import applyDefaults from '../../../../src/scene/structure/apply-defaults.js'
 import window3d from '../../../../src/scene/structure/parametric-objects/window'
+import { isNaN } from 'lodash'
 
 // mock runtime module to prevent from tests blowing up
 jest.mock('../../../../src/core/runtime.js', () => ({isBrowser: false, isNode: true}))
@@ -12,4 +13,7 @@ test('get window data3d', async function(){
   expect(Object.keys(data3d.meshes)).toEqual([ 'frame', 'glass' ])
   expect(data3d.meshes.frame.positions).toBeDefined()
   expect(data3d.meshes.frame.normals).toBeDefined()
+  // check for valid vertices
+  expect(data3d.meshes.frame.positions.every(a => !isNaN(a))).toBeTruthy()
+  expect(data3d.meshes.glass.positions.every(a => !isNaN(a))).toBeTruthy()
 });