Skip to content

[Bug]-[130]:File picker Widget - able to pick a file when Max no of files is defined as zero (0) #14857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 task done
Sripriya93 opened this issue Jun 28, 2022 · 5 comments · May be fixed by #34893
Open
1 task done

[Bug]-[130]:File picker Widget - able to pick a file when Max no of files is defined as zero (0) #14857

Sripriya93 opened this issue Jun 28, 2022 · 5 comments · May be fixed by #34893
Labels
Bug Something isn't working File Picker Widget Low An issue that is neither critical nor breaks a user flow Production Query Widgets & IDE Pod All issues related to Query, JS, Eval, Widgets & IDE Widgets & Accelerators Pod Issues related to widgets & Accelerators Widgets Product This label groups issues related to widgets

Comments

@Sripriya93
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Description

When Max no of files defined in a File picker is set to zero, we are able to pick a file by default.

Expected: The File picker widget should not allow the user to pick any files

Steps To Reproduce

  1. Drag and drop a File picker widget
  2. Change the Max no of files to 0 (Zero)
  3. Now click on "Select file", select a file and click on open

Expected: Error message saying "Cannot upload any files" as max no of file is set to zero

Public Sample App

No response

Version

Release and production
@Sripriya93 Sripriya93 added Bug Something isn't working Needs Triaging Needs attention from maintainers to triage labels Jun 28, 2022
@Sripriya93 Sripriya93 added Low An issue that is neither critical nor breaks a user flow File Picker Widget labels Jun 28, 2022
@github-actions github-actions bot added the Widgets Product This label groups issues related to widgets label Jun 28, 2022
@dilippitchika
Copy link
Contributor

A dev should not be able to set the value of max files to 0. We have to add this validation in this property. If they want to set it 0, it's better they disable it.

@dilippitchika
Copy link
Contributor

@iamrkcheers assigning this issue to you, proposed fix is the following

  1. For the max files field, add a validation to not accept 0.
  2. When 0 is still bound using some api or variable, disable the widget altogether

@dilippitchika
Copy link
Contributor

Stats

Stat Values
Reach 130
Effort (months) 0.5

@Nikhil-Nandagopal Nikhil-Nandagopal changed the title [Bug]: File picker Widget - able to pick a file when Max no of files is defined as zero (0) [Bug]-[130]:File picker Widget - able to pick a file when Max no of files is defined as zero (0) Jul 1, 2022
@dilippitchika dilippitchika added Good First Issue Good for newcomers and removed Needs Triaging Needs attention from maintainers to triage labels Jul 1, 2022
@ShivangMishra
Copy link

@dilippitchika Can you assign this issue to me ?

@iamrkcheers iamrkcheers mentioned this issue Oct 13, 2022
Closed
1 task
@somangshu somangshu removed the Good First Issue Good for newcomers label Oct 21, 2022
Open
@saiprabhu-dandanayak
Copy link
Contributor

Hi @dilippitchika , @somangshu , i have rasied PR on this Bug , could you pls review it.

@rohan-arthur rohan-arthur linked a pull request Jul 12, 2024 that will close this issue
Open
2 tasks
@Nikhil-Nandagopal Nikhil-Nandagopal added the Widgets & Accelerators Pod Issues related to widgets & Accelerators label Aug 6, 2024
@vivek-appsmith vivek-appsmith added the Query Widgets & IDE Pod All issues related to Query, JS, Eval, Widgets & IDE label Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working File Picker Widget Low An issue that is neither critical nor breaks a user flow Production Query Widgets & IDE Pod All issues related to Query, JS, Eval, Widgets & IDE Widgets & Accelerators Pod Issues related to widgets & Accelerators Widgets Product This label groups issues related to widgets
Projects
None yet
Milestone
No milestone
9 participants
@Nikhil-Nandagopal @somangshu @iamrkcheers @dilippitchika @ShivangMishra @btsgh @Sripriya93 @saiprabhu-dandanayak @vivek-appsmith