PR feedback, move to a string to be able to support other operation loading techniques

Author: swcollard

crates/apollo-mcp-registry/src/uplink/persisted_queries/event.rs

@@ -4,7 +4,7 @@ use std::fmt::Formatter;
 /// Persisted Query events
 pub enum Event {
     /// The persisted query manifest was updated
-    UpdateManifest(Vec<(String, String)>),
+    UpdateManifest(Vec<(String, String, String)>),
 }
 
 impl Debug for Event {

crates/apollo-mcp-registry/src/uplink/persisted_queries/manifest_poller.rs

@@ -38,7 +38,13 @@ impl ManifestSource {
                     Ok(manifest) => Event::UpdateManifest(
                         manifest
                             .iter()
-                            .map(|(k, v)| (k.operation_id.clone(), v.clone()))
+                            .map(|(k, v)| {
+                                (
+                                    k.operation_id.clone(),
+                                    v.clone(),
+                                    "PersistedQuery".to_string(),
+                                )
+                            })
                             .collect(),
                     ),
                     Err(e) => {

crates/apollo-mcp-server/src/errors.rs

@@ -1,5 +1,3 @@
-use std::path::PathBuf;
-
 use apollo_compiler::{Schema, ast::Document, validation::WithErrors};
 use apollo_federation::error::FederationError;
 use reqwest::header::{InvalidHeaderName, InvalidHeaderValue};
@@ -16,16 +14,16 @@ pub enum OperationError {
     Internal(String),
 
     #[error("{0}: Operation is missing its required name: {1}")]
-    MissingName(PathBuf, String),
+    MissingName(String, String),
 
     #[error("{0}: No operations defined")]
-    NoOperations(PathBuf),
+    NoOperations(String),
 
     #[error("Invalid JSON: {0}")]
     Json(#[from] serde_json::Error),
 
     #[error("{0}: Too many operations. Expected 1 but got {1}")]
-    TooManyOperations(PathBuf, usize),
+    TooManyOperations(String, usize),
 
     #[error(transparent)]
     File(#[from] std::io::Error),

crates/apollo-mcp-server/src/introspection.rs

@@ -173,8 +173,12 @@ impl graphql::Executable for Execute {
         })?;
 
         // validate the operation
-        operation_defs(&input.query, self.mutation_mode == MutationMode::All, &None)
-            .map_err(|e| McpError::new(ErrorCode::INVALID_PARAMS, e.to_string(), None))?;
+        operation_defs(
+            &input.query,
+            self.mutation_mode == MutationMode::All,
+            "Introspection".to_string(),
+        )
+        .map_err(|e| McpError::new(ErrorCode::INVALID_PARAMS, e.to_string(), None))?;
 
         Ok(input.query)
     }