test: switch from ubuntu-22.04 to 24.04 (#1480)

* test: switch from ubuntu-22.04 to 24.04

* Updated runner.ts

* Updated test-setup.sh

* Updated test-setup.sh

* Reverted changes done on test setup

* stop, disabled and masked apparmor

* made changes to test-setup.py

* updated test setup

* Testing disabling artifact creation with navigator runs

* Try testing podman outside of the ui tests

* Add cgroup manager config as per podman-desktop pull 7266

* updated terminaluitest

---------

Co-authored-by: tanwigeetika1618 <[email protected]>
Co-authored-by: Shashank Venkat <shvenkat>
Co-authored-by: alisonlhart <[email protected]>

Author: 3 people

.config/dictionary.txt

@@ -65,6 +65,7 @@ bitness
 bthornto
 cacheable
 cfgs
+cgroupfs
 charliermarsh
 checode
 chromedriver

.github/workflows/ci.yaml

@@ -49,7 +49,7 @@ jobs:
       run:
         shell: ${{ matrix.shell || 'bash'}}
     # The type of runner that the job will run on
-    runs-on: ${{ matrix.os || 'ubuntu-22.04' }}
+    runs-on: ${{ matrix.os || 'ubuntu-24.04' }}
     # see https://github.com/containers/podman/issues/13609
     continue-on-error: ${{ contains(matrix.name, 'macos') && true || false }}
     outputs:
@@ -63,15 +63,15 @@ jobs:
         continue-on-error:
           - false
         os:
-          - ubuntu-22.04
+          - ubuntu-24.04
         task-name:
           - docs
         name:
           - docs
         include:
           - name: lint
             task-name: lint
-            os: ubuntu-22.04
+            os: ubuntu-24.04
             env:
               SKIP_PODMAN: 1
               SKIP_DOCKER: 1
@@ -110,7 +110,7 @@ jobs:
         if: contains(matrix.shell, 'wsl')
         uses: Vampire/[email protected]
         with:
-          distribution: Ubuntu-22.04
+          distribution: Ubuntu-24.04
           set-as-default: "true"
           # '-i' seems to be the only option that loads .bashrc file that we need
           # https://github.com/Vampire/setup-wsl/discussions/54
@@ -132,6 +132,7 @@ jobs:
             dbus
             dirmngr
             gawk
+            gcc
             git
             gpg
             gpg-agent
@@ -246,6 +247,20 @@ jobs:
         run: |
           task package ${{ matrix.env.TASKFILE_ARGS }}
 
+      # Temporary step for debugging https://github.com/ansible/vscode-ansible/pull/1480
+      - name: test podman issue
+        if: ${{ matrix.name == 'test (linux)' }}
+        run: |
+          sudo sysctl -w kernel.apparmor_restrict_unprivileged_userns=0
+          mkdir -p ~/.config/containers
+          cat <<EOT >> ~/.config/containers/containers.conf
+          [engine]
+          cgroup_manager="cgroupfs"
+          EOT
+          podman info
+          ansible-navigator run ./test/testFixtures/terminal/playbook.yml --ee true --ce podman --eei ghcr.io/ansible/community-ansible-dev-tools:latest --mode stdout --pae false
+
+
       - name: task ${{ matrix.task-name }}
         if: "${{ !contains(matrix.name, 'test') }}"
         run: task ${{ matrix.task-name }} ${{ matrix.env.TASKFILE_ARGS }}
@@ -344,7 +359,7 @@ jobs:
       id-token: write
       checks: read
 
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
 
     steps:
       - name: Merge logs into a single archive

.readthedocs.yml

@@ -21,10 +21,10 @@ submodules:
   recursive: true
 
 build:
-  os: ubuntu-22.04
+  os: ubuntu-24.04
   tools:
     python: >-  # PyYAML parses it as float `3.1` it it's not an explicit string
-      3.10
+      3.12
 
 # Optionally set the version of Python and requirements required
 # to build docs

src/features/runner.ts

@@ -59,6 +59,8 @@ export class AnsiblePlaybookRunProvider {
       return;
     }
     commandLineArgs.push("--ee true");
+    commandLineArgs.push("--mode stdout");
+    commandLineArgs.push("--pae false");
     commandLineArgs.push(
       `--ce ${getContainerEngine(eeSettings.containerEngine)}`,
     );

test/ui-test/terminalUiTest.ts

@@ -89,7 +89,7 @@ describe("Verify the execution of playbook using ansible-navigator command", ()
       const text = await terminalView.getText();
 
       // assert with just "Play " rather than "Play name" due to CI output formatting issues
-      expect(text).contains("Play ");
+      expect(text.replace(/\s+/g, " ")).contains("PLAY [");
       await terminalView.killTerminal();
     }
   });

tools/test-setup.sh

@@ -1,5 +1,5 @@
 #!/bin/bash
-# cSpell:ignore RPMS xorg cmdtest corepack xrandr nocolor
+# cSpell:ignore RPMS xorg cmdtest corepack xrandr nocolor userns
 #
 # This tool is used to setup the environment for running the tests. Its name
 # name and location is based on Zuul CI, which can automatically run it.
@@ -129,11 +129,35 @@ if [[ -f "/etc/redhat-release" ]]; then
     fi
 fi
 
+# Fail-fast if run on Windows or under WSL1/2 on /mnt/c because it is so slow
+# that we do not support it at all. WSL use is ok, but not on mounts.
+WSL=0
+if [[ "${OS:-}" == "windows" ]]; then
+    log error "You cannot use Windows build tools for development, try WSL."
+    exit 1
+fi
+if grep -qi microsoft /proc/version >/dev/null 2>&1; then
+    # resolve pwd symlinks and ensure than we do not run under /mnt (mount)
+    if [[ "$(pwd -P || true)" == /mnt/* ]]; then
+        log warning "Under WSL, you must avoid running from mounts (/mnt/*) due to critical performance issues."
+    fi
+    WSL=1
+fi
+
 if [[ -f "/usr/bin/apt-get" ]]; then
     INSTALL=0
     # qemu-user-static is required by podman on arm64
     # python3-dev is needed for headers as some packages might need to compile
 
+    # if [[ "$WSL" == "0" ]] && [[ "$(sysctl -n kernel.apparmor_restrict_unprivileged_userns)" != "0" ]]; then
+    #     log warning "AppArmor restricts unprivileged user namespaces, disabling it for testing. See https://github.com/redhat-developer/vscode-extension-tester/issues/1496"
+    #     sudo sysctl -w kernel.apparmor_restrict_unprivileged_userns=0
+
+    #     #sudo sysctl stop apparmor
+    #     #sudo sysctl disable apparmor
+    #     #sudo sysctl mask apparmor
+    # fi
+
     DEBS=(curl git python3-dev python3-venv python3-pip qemu-user-static xvfb x11-xserver-utils libgbm-dev libssh-dev libonig-dev)
     # add nodejs to DEBS only if node is not already installed because
     # GHA has newer versions preinstalled and installing the rpm would
@@ -202,21 +226,6 @@ if [[ "${OS:-}" == "darwin" && "${SKIP_PODMAN:-}" != '1' ]]; then
     }
 fi
 
-# Fail-fast if run on Windows or under WSL1/2 on /mnt/c because it is so slow
-# that we do not support it at all. WSL use is ok, but not on mounts.
-WSL=0
-if [[ "${OS:-}" == "windows" ]]; then
-    log error "You cannot use Windows build tools for development, try WSL."
-    exit 1
-fi
-if grep -qi microsoft /proc/version >/dev/null 2>&1; then
-    # resolve pwd symlinks and ensure than we do not run under /mnt (mount)
-    if [[ "$(pwd -P || true)" == /mnt/* ]]; then
-        log warning "Under WSL, you must avoid running from mounts (/mnt/*) due to critical performance issues."
-    fi
-    WSL=1
-fi
-
 # User specific environment
 if ! [[ "${PATH}" == *"${HOME}/.local/bin"* ]]; then
     # shellcheck disable=SC2088
@@ -335,7 +344,7 @@ if [[ -n "${CI:-}" ]]; then
 fi
 
 # Fail if detected tool paths are not from inside out out/ folder
-for CMD in ansible ansible-lint; do
+for CMD in ansible ansible-lint ansible-navigator; do
     CMD=$(command -v $CMD 2>/dev/null)
     [[ "${CMD}" == "$VIRTUAL_ENV"* ]] || {
         log error "${CMD} executable is not from our own virtualenv ($VIRTUAL_ENV)"
@@ -344,6 +353,10 @@ for CMD in ansible ansible-lint; do
 done
 unset CMD
 
+# Validate navigator ability to use ee
+#ansible-navigator run ./test/testFixtures/terminal/playbook.yml --ee false --mode stdout
+#ansible-navigator run ./test/testFixtures/terminal/playbook.yml --ee true --ce podman --eei ghcr.io/ansible/community-ansible-dev-tools:latest --mode stdout
+
 command -v npm  >/dev/null 2>&1 || {
     log notice "Installing nodejs stable."
     asdf install