Skip to content

Commit 9520371

Browse files
vax-rJoel Fernandes
authored and
Joel Fernandes
committed
rust: sync: rcu: Mark Guard methods as inline
Currently the implementation of "Guard" methods are basically wrappers around rcu's function within kernel. Building the kernel with llvm 18.1.8 on x86_64 machine will generate the following symbols: $ nm vmlinux | grep ' _R'.*Guard | rustfilt ffffffff817b6c90 T <kernel::sync::rcu::Guard>::new ffffffff817b6cb0 T <kernel::sync::rcu::Guard>::unlock ffffffff817b6cd0 T <kernel::sync::rcu::Guard as core::ops::drop::Drop>::drop ffffffff817b6c90 T <kernel::sync::rcu::Guard as core::default::Default>::default These Rust symbols are basically wrappers around functions "rcu_read_lock" and "rcu_read_unlock". Marking them as inline can reduce the generation of these symbols, and saves the size of code generation for 132 bytes. $ ./scripts/bloat-o-meter vmlinux_old vmlinux_new (Output is demangled for readability) add/remove: 0/10 grow/shrink: 0/1 up/down: 0/-132 (-132) Function old new delta rust_driver_pci::SampleDriver::probe 1041 1034 -7 kernel::sync::rcu::Guard::default 9 - -9 kernel::sync::rcu::Guard::drop 9 - -9 kernel::sync::rcu::read_lock 9 - -9 kernel::sync::rcu::Guard::unlock 9 - -9 kernel::sync::rcu::Guard::new 9 - -9 __pfx__kernel::sync::rcu::Guard::default 16 - -16 __pfx__kernel::sync::rcu::Guard::drop 16 - -16 __pfx__kernel::sync::rcu::read_lock 16 - -16 __pfx__kernel::sync::rcu::Guard::unlock 16 - -16 __pfx__kernel::sync::rcu::Guard::new 16 - -16 Total: Before=23365955, After=23365823, chg -0.00% Link: Rust-for-Linux#1145 Signed-off-by: I Hsin Cheng <[email protected]> Reviewed-by: Joel Fernandes <[email protected]> Reviewed-by: Benno Lossin <[email protected]> Reviewed-by: Charalampos Mitrodimas <[email protected]> Acked-by: Miguel Ojeda <[email protected]> Signed-off-by: Joel Fernandes <[email protected]>
1 parent da6b855 commit 9520371

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

rust/kernel/sync/rcu.rs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ pub struct Guard(NotThreadSafe);
1717

1818
impl Guard {
1919
/// Acquires the RCU read side lock and returns a guard.
20+
#[inline]
2021
pub fn new() -> Self {
2122
// SAFETY: An FFI call with no additional requirements.
2223
unsafe { bindings::rcu_read_lock() };
@@ -25,23 +26,27 @@ impl Guard {
2526
}
2627

2728
/// Explicitly releases the RCU read side lock.
29+
#[inline]
2830
pub fn unlock(self) {}
2931
}
3032

3133
impl Default for Guard {
34+
#[inline]
3235
fn default() -> Self {
3336
Self::new()
3437
}
3538
}
3639

3740
impl Drop for Guard {
41+
#[inline]
3842
fn drop(&mut self) {
3943
// SAFETY: By the type invariants, the RCU read side is locked, so it is ok to unlock it.
4044
unsafe { bindings::rcu_read_unlock() };
4145
}
4246
}
4347

4448
/// Acquires the RCU read side lock.
49+
#[inline]
4550
pub fn read_lock() -> Guard {
4651
Guard::new()
4752
}

0 commit comments

Comments
 (0)