Skip to content

Commit cdb99ff

Browse files
authored
Merge pull request #515 from almarklein/prevent-gap
Prevent gap when having many small records
2 parents ce76e2f + 7f7bf89 commit cdb99ff

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

timetagger/app/front.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2129,6 +2129,10 @@ def _determine_record_preferred_pos(self, record, t1, y0, y1, y2, npixels, nsecs
21292129
ry1 = y0 + npixels * (record.t1 - t1) / nsecs
21302130
ry2 = y0 + npixels * (t2_or_now - t1) / nsecs
21312131

2132+
# Get margin for making space for record before its visible
2133+
npixels_record = max(0, ry2 - ry1)
2134+
visible_margin = min(npixels_record, 40)
2135+
21322136
# Determine preferred position
21332137
pref = y = (ry1 + ry2) / 2
21342138
visible = "main"
@@ -2138,15 +2142,15 @@ def _determine_record_preferred_pos(self, record, t1, y0, y1, y2, npixels, nsecs
21382142
if ry2 < y1:
21392143
# Start claiming space before it is visible
21402144
y -= 2 * (y1 - ry2)
2141-
if ry2 < y1 - 40:
2145+
if ry2 < y1 - visible_margin:
21422146
visible = ""
21432147
elif y > y2 - 20:
21442148
y = y2 - 20
21452149
visible = "bottom"
21462150
if ry1 > y2:
21472151
# Start claiming space before it is visible
21482152
y += 2 * (ry1 - y2)
2149-
if ry1 > y2 + 40:
2153+
if ry1 > y2 + visible_margin:
21502154
visible = ""
21512155

21522156
return {"pref": pref, "y": y, "visible": visible}

0 commit comments

Comments
 (0)