Merge pull request #136 from techinasia/cleanup-tests

Cleanup Tests

Author: rayrutjes

tests/AlgoliaEloquentTraitTest.php

@@ -99,8 +99,6 @@ public function testSetSettings()
         $this->assertEquals($modelHelper->getFinalIndexName($model12, $realModelHelper->getSettings($model12)['slaves'][0]), 'model_6_desc_testing');
 
         $model12->setSettings();
-
-
     }
 
     public function testSetSettingsMerge()
@@ -175,7 +173,8 @@ public function testSetSynonyms()
         $this->assertEquals(null, $model10->setSettings());
     }
 
-    function testPustToIndexWithgetAlgoliaRecordAndIndexName() {
+    public function testPushToIndexWithGetAlgoliaRecordAndIndexName()
+    {
         /** @var \AlgoliaSearch\Laravel\ModelHelper $realModelHelper */
         $realModelHelper = App::make('\AlgoliaSearch\Laravel\ModelHelper');
 
@@ -193,13 +192,8 @@ function testPustToIndexWithgetAlgoliaRecordAndIndexName() {
         App::instance('\AlgoliaSearch\Laravel\ModelHelper', $modelHelper);
 
 
-        $index->shouldReceive('addObject')->times(1)->with(["is" => "working", "objectID" => null]);
+        $index->shouldReceive('addObject')->times(1)->with(['is' => 'working', 'objectID' => null]);
 
         $this->assertEquals(null, (new Model11())->pushToIndex());
     }
-
-    public function tearDown()
-    {
-        Mockery::close();
-    }
 }

tests/EloquentSubscriberTest.php

@@ -5,7 +5,6 @@
 use AlgoliaSearch\Laravel\EloquentSubscriber;
 use AlgoliaSearch\Tests\Models\Model1;
 
-
 class EloquentSubscriberTest extends \PHPUnit_Framework_TestCase
 {
     /**
@@ -57,7 +56,4 @@ public function listenerDataProvider()
             ['eloquent.event', [new Model1()]], // Laravel 5.4
         ];
     }
-
-
-
 }

tests/ModelHelperTest.php

@@ -25,6 +25,7 @@ public function setUp()
 
         $this->modelHelper = $this->app->make('\AlgoliaSearch\Laravel\ModelHelper');
     }
+
     public function testAutoIndexAndAutoDelete()
     {
         $this->assertEquals(true, $this->modelHelper->isAutoIndex(new Model1()));
@@ -77,7 +78,7 @@ public function testGetIndices()
 
         $indices = $this->modelHelper->getIndices(new Model2());
 
-        $this->assertEquals(2, count($indices));
+        $this->assertCount(2, $indices);
         $this->assertEquals('index1', $indices[0]->indexName);
     }
 }

tests/Models/Model10.php

@@ -7,6 +7,7 @@
 class Model10 extends Model
 {
     use AlgoliaEloquentTrait;
+
     public $algoliaSettings = [
         'synonyms' => [
             [

tests/Models/Model11.php

@@ -14,6 +14,7 @@ public function getAlgoliaRecord($indexName)
         if ($indexName == 'model11s') {
             return ["is" => "working"];
         }
+
         return ["is not" => "working"];
     }
 }