Allow commas in numeric string values (#29)

Author: Abdullah-l

lib/mini_defender/rules/numeric.rb

@@ -6,11 +6,27 @@ def self.signature
   end
 
   def coerce(value)
-    value.is_a?(Numeric) ? value : Float(value.to_s)
+    if value.is_a?(Numeric)
+      return value
+    end
+
+    if value.is_a?(String)
+      value = value.gsub(',', '')
+    end
+
+    Float(value.to_s)
   end
 
   def passes?(attribute, value, validator)
-    value.is_a?(Numeric) || Float(value.to_s) rescue false
+    if value.is_a?(Numeric)
+      return true
+    end
+
+    if value.is_a?(String)
+      value = value.gsub(',', '')
+    end
+
+    Float(value.to_s) rescue false
   end
 
   def message(attribute, value, validator)

lib/mini_defender/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module MiniDefender
-  VERSION = "0.6.8"
+  VERSION = "0.6.9"
 end

test/rules/numeric_test.rb

@@ -3,5 +3,83 @@
 require 'test_helper'
 
 class NumericTest < Minitest::Test
+  def setup
+    @rule = MiniDefender::Rules::Numeric.new
+  end
 
+  def test_passes_with_integer
+    assert @rule.passes?(nil, 25, true)
+  end
+
+  def test_passes_with_float
+    assert @rule.passes?(nil, 19.99, true)
+  end
+
+  def test_passes_with_zero
+    assert @rule.passes?(nil, 0, true)
+  end
+
+  def test_passes_with_negative_number
+    assert @rule.passes?(nil, -10, true)
+  end
+
+  def test_passes_with_numeric_string
+    assert @rule.passes?(nil, "42", true)
+  end
+
+  def test_passes_with_float_string
+    assert @rule.passes?(nil, "72.5", true)
+  end
+
+  def test_passes_with_string_with_commas
+    assert @rule.passes?(nil, "50,000", true)
+  end
+
+  def test_fails_with_non_numeric_string
+    refute @rule.passes?(nil, "John", true)
+  end
+
+  def test_fails_with_empty_string
+    refute @rule.passes?(nil, "", true)
+  end
+
+  def test_fails_with_nil
+    refute @rule.passes?(nil, nil, true)
+  end
+
+  def test_fails_with_boolean
+    refute @rule.passes?(nil, true, true)
+  end
+
+  def test_fails_with_array
+    refute @rule.passes?(nil, [1, 2, 3], true)
+  end
+
+  def test_fails_with_hash
+    refute @rule.passes?(nil, { key: "value" }, true)
+  end
+
+  def test_coerce_with_integer
+    assert_equal 42, @rule.coerce(42)
+  end
+
+  def test_coerce_with_float
+    assert_equal 3.14, @rule.coerce(3.14)
+  end
+
+  def test_coerce_with_numeric_string
+    assert_equal 42.0, @rule.coerce("42")
+  end
+
+  def test_coerce_with_string_with_commas
+    assert_equal 1000.0, @rule.coerce("1,000")
+  end
+
+  def test_coerce_raises_error_with_non_numeric_string
+    assert_raises(ArgumentError) { @rule.coerce("abc") }
+  end
+
+  def test_message
+    assert_equal "The field must contain a numeric value.", @rule.message(nil, "abc", true)
+  end
 end