Remove unused code and add TODO comments for future improvements

Author: trheyi

v8go.cc

@@ -130,13 +130,15 @@ extern "C" {
 
 static IsolatePtr globalIsolate = nullptr;
 
+// Clean up the global isolate
 void YaoDispose() {
   if (globalIsolate != nullptr ) {
     globalIsolate->Dispose();
     globalIsolate = nullptr;
   }
 }
 
+// @todo: create from snapshot
 IsolatePtr YaoNewIsolate() {
   Isolate::CreateParams params;
   params.array_buffer_allocator = default_allocator;
@@ -156,7 +158,7 @@ IsolatePtr YaoNewIsolate() {
   return iso;
 }
 
-
+// @todo: Remove after snapshot works
 IsolatePtr YaoNewIsolateFromGlobal() {
   if (globalIsolate == nullptr) {
     return nullptr;
@@ -166,6 +168,7 @@ IsolatePtr YaoNewIsolateFromGlobal() {
   return ptr;
 }
 
+// @todo: use internal context, after snapshot works
 ContextPtr YaoIsolateContext( IsolatePtr iso ) {
   if (iso == nullptr) {
     return nullptr;
@@ -180,6 +183,7 @@ extern IsolatePtr YaoCopyIsolate( IsolatePtr iso ) {
 }
 
 
+// @todo: remove after snapshot works
 // Should call in the main thread only
 void YaoIsolateAsGlobal( IsolatePtr iso ) {
   if (globalIsolate != nullptr) {

yao_test.go

@@ -54,22 +54,21 @@ func TestYaoIsolateContext(t *testing.T) {
 	}
 }
 
-func TestYaoNewIsolateFromGlobal(t *testing.T) {
-	v8.YaoInit(1024)
-	defer v8.YaoDispose()
-
-	iso := v8.YaoNewIsolate()
-	iso.AsGlobal()
-	iso.Dispose()
-	iso = nil
-
-	new, err := v8.YaoNewIsolateFromGlobal()
-	if err != nil {
-		t.Error(err)
-	}
-
-	if new == nil {
-		t.Errorf("new is nil")
-	}
-	defer new.Dispose()
-}
+// func TestYaoNewIsolateFromGlobal(t *testing.T) {
+// 	v8.YaoInit(1024)
+// 	defer v8.YaoDispose()
+
+// 	iso := v8.YaoNewIsolate()
+// 	iso.AsGlobal()
+// 	iso.Dispose()
+
+// 	new, err := v8.YaoNewIsolateFromGlobal()
+// 	if err != nil {
+// 		t.Error(err)
+// 	}
+
+// 	if new == nil {
+// 		t.Errorf("new is nil")
+// 	}
+// 	defer new.Dispose()
+// }