Skip to content

Commit 2327f9a

Browse files
authored
Add Node.js v22. Drop ancient EOL versions of Node.js and Electron (#1182)
Drop unsupported versions of node and electron
1 parent 608f115 commit 2327f9a

File tree

3 files changed

+14
-9
lines changed

3 files changed

+14
-9
lines changed

.github/workflows/build.yml

+12-7
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,12 @@ on:
1313
workflow_dispatch: {}
1414

1515
env:
16-
NODE_BUILD_CMD: npx --no-install prebuild -r node -t 18.0.0 -t 20.0.0 -t 21.0.0 --include-regex 'better_sqlite3.node$'
17-
ELECTRON_BUILD_CMD: npx --no-install prebuild -r electron -t 16.0.0 -t 17.0.0 -t 18.0.0 -t 19.0.0 -t 20.0.0 -t 21.0.0 -t 22.0.0 -t 23.0.0 -t 24.0.0 -t 25.0.0 -t 26.0.0 -t 27.0.0 -t 28.0.0 -t 29.0.0 -t 30.0.0 --include-regex 'better_sqlite3.node$'
16+
# See https://nodejs.org/en/about/previous-releases
17+
# Node.js 16 EOL = 11 Sep 2023
18+
NODE_BUILD_CMD: npx --no-install prebuild -r node -t 18.0.0 -t 20.0.0 -t 21.0.0 -t 22.0.0 --include-regex 'better_sqlite3.node$'
19+
# See https://www.electronjs.org/docs/latest/tutorial/electron-timelines#version-support-policy
20+
# The v25 EOL = 2023-dec-5. v26 EOL = 2024-feb-20. v27 EOL = 2024-apr-16. v28 EOL = 2024-jun-11. v29 EOL = 2024-aug-20.
21+
ELECTRON_BUILD_CMD: npx --no-install prebuild -r electron -t 25.0.0 -t 26.0.0 -t 27.0.0 -t 28.0.0 -t 29.0.0 -t 30.0.0 --include-regex 'better_sqlite3.node$'
1822

1923
jobs:
2024
test:
@@ -29,6 +33,7 @@ jobs:
2933
- 18
3034
- 20
3135
- 21
36+
- 22
3237
name: Testing Node ${{ matrix.node }} on ${{ matrix.os }}
3338
runs-on: ${{ matrix.os }}
3439
steps:
@@ -61,7 +66,7 @@ jobs:
6166
- uses: actions/checkout@v4
6267
- uses: actions/setup-node@v4
6368
with:
64-
node-version: 16
69+
node-version: 18
6570
registry-url: https://registry.npmjs.org
6671
- run: npm publish
6772
env:
@@ -82,7 +87,7 @@ jobs:
8287
- uses: actions/checkout@v4
8388
- uses: actions/setup-node@v4
8489
with:
85-
node-version: 16
90+
node-version: 18
8691
- if: ${{ startsWith(matrix.os, 'windows') }}
8792
run: pip.exe install setuptools
8893
- if: ${{ startsWith(matrix.os, 'macos') }}
@@ -102,7 +107,7 @@ jobs:
102107
prebuild-alpine:
103108
name: Prebuild on alpine
104109
runs-on: ubuntu-latest
105-
container: node:16-alpine
110+
container: node:18-alpine
106111
needs: publish
107112
steps:
108113
- uses: actions/checkout@v4
@@ -123,7 +128,7 @@ jobs:
123128
- uses: actions/checkout@v4
124129
- uses: docker/setup-qemu-action@v3
125130
- run: |
126-
docker run --rm -v $(pwd):/tmp/project --entrypoint /bin/sh --platform linux/${{ matrix.arch }} node:16-alpine -c "\
131+
docker run --rm -v $(pwd):/tmp/project --entrypoint /bin/sh --platform linux/${{ matrix.arch }} node:18-alpine -c "\
127132
apk add build-base git python3 py3-setuptools --update-cache && \
128133
cd /tmp/project && \
129134
npm install --ignore-scripts && \
@@ -142,7 +147,7 @@ jobs:
142147
- uses: actions/checkout@v4
143148
- uses: docker/setup-qemu-action@v3
144149
- run: |
145-
docker run --rm -v $(pwd):/tmp/project --entrypoint /bin/sh --platform linux/${{ matrix.arch }} node:16 -c "\
150+
docker run --rm -v $(pwd):/tmp/project --entrypoint /bin/sh --platform linux/${{ matrix.arch }} node:18 -c "\
146151
cd /tmp/project && \
147152
npm install --ignore-scripts && \
148153
${{ env.NODE_BUILD_CMD }} -u ${{ secrets.GITHUB_TOKEN }}"

.github/workflows/bump-version.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323
fetch-depth: 0
2424
- uses: actions/setup-node@v4
2525
with:
26-
node-version: 16
26+
node-version: 18
2727
- name: Configure user
2828
run: |
2929
git config --local user.name "${{ github.actor }}"

.github/workflows/update-sqlite.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424
fetch-depth: 0
2525
- uses: actions/setup-node@v4
2626
with:
27-
node-version: 16
27+
node-version: 18
2828
- name: Create new update branch
2929
run: git checkout -b sqlite-update-${{ env.ENV_VERSION }}
3030
- name: Update download script

0 commit comments

Comments
 (0)