fix UnitySQL::requestExists

Author: simonLeary42

resources/autoload.php

@@ -24,6 +24,8 @@
 require_once __DIR__ . "/lib/UnityWebhook.php";
 require_once __DIR__ . "/lib/UnityRedis.php";
 require_once __DIR__ . "/lib/UnityGithub.php";
+require_once __DIR__ . "/lib/exceptions/PhpUnitNoDieException.php";
+require_once __DIR__ . "/lib/exceptions/UnitySQLNoSuchRequestException.php";
 
 // run init script
 require __DIR__ . "/init.php";

resources/lib/UnitySQL.php

@@ -3,6 +3,8 @@
 namespace UnityWebPortal\lib;
 
 use PDO;
+use Exception;
+use UnityWebPortal\lib\exceptions\UnitySQLNoSuchRequestException;
 
 class UnitySQL
 {
@@ -94,7 +96,7 @@ public function getRequest($user, $dest)
         $stmt->execute();
         $result = $stmt->fetchAll();
         if (count($result) == 0) {
-            throw new Exception("no such request: uid='$user' request_for='$dest'");
+            throw new UnitySQLNoSuchRequestException("no such request: uid='$user' request_for='$dest'");
         }
         if (count($result) > 1) {
             throw new Exception("too many requests for uid='$user' request_for='$dest'");
@@ -104,7 +106,12 @@ public function getRequest($user, $dest)
 
     public function requestExists($requestor, $dest = self::REQUEST_BECOME_PI)
     {
-        return (!is_null(self::getRequest($requestor, $dest)));
+        try {
+            self::getRequest($requestor, $dest);
+            return true;
+        } catch (UnitySQLNoSuchRequestException) {
+            return false;
+        }
     }
 
     public function getRequests($dest = self::REQUEST_BECOME_PI)

resources/lib/exceptions/UnitySQLNoSuchRequestException.php

@@ -0,0 +1,6 @@
+<?php
+namespace UnityWebPortal\lib\exceptions;
+
+class UnitySQLNoSuchRequestException extends \Exception
+{
+}