make sql exception more generic

Author: simonLeary42

resources/autoload.php

@@ -25,7 +25,7 @@
 require_once __DIR__ . "/lib/UnityRedis.php";
 require_once __DIR__ . "/lib/UnityGithub.php";
 require_once __DIR__ . "/lib/exceptions/PhpUnitNoDieException.php";
-require_once __DIR__ . "/lib/exceptions/UnitySQLNoSuchRequestException.php";
+require_once __DIR__ . "/lib/exceptions/UnitySQLRecordNotFound.php";
 
 // run init script
 require __DIR__ . "/init.php";

resources/lib/UnitySQL.php

@@ -4,7 +4,7 @@
 
 use PDO;
 use PDOException;
-use UnityWebPortal\lib\exceptions\UnitySQLNoSuchRequestException;
+use UnityWebPortal\lib\exceptions\UnitySQLRecordNotFound;
 
 class UnitySQL
 {
@@ -147,7 +147,7 @@ public function getRequest($user, $dest)
     {
         $results = $this->search(self::TABLE_REQS, ["request_for" => $dest]);
         if (count($results) == 0) {
-            throw new UnitySQLNoSuchRequestException("no such request: uid='$user' request_for='$dest'");
+            throw new UnitySQLRecordNotFound("no such request: uid='$user' request_for='$dest'");
         }
         if (count($results) > 1) {
             throw new Exception("too many requests for uid='$user' request_for='$dest'");
@@ -160,7 +160,7 @@ public function requestExists($requestor, $dest = self::REQUEST_BECOME_PI)
         try {
             self::getRequest($requestor, $dest);
             return true;
-        } catch (UnitySQLNoSuchRequestException) {
+        } catch (UnitySQLRecordNotFound) {
             return false;
         }
     }
@@ -266,6 +266,9 @@ public function deleteAccountDeletionRequest($uid)
     public function getSiteVar($name): string
     {
         $results = $this->search(self::TABLE_SITEVARS, ["name" => $name]);
+        if (count($results) == 0) {
+            throw new UnitySQLRecordNotFound($name);
+        }
         assert(count($results) == 1);
         return $results[0]["value"];
     }

resources/lib/exceptions/UnitySQLNoSuchRequestException.php

@@ -0,0 +1,6 @@
+<?php
+namespace UnityWebPortal\lib\exceptions;
+
+class UnitySQLRecordNotFound extends \Exception
+{
+}

resources/lib/exceptions/UnitySQLRecordNotFound.php

@@ -19,6 +19,7 @@
 require_once __DIR__ . "/../resources/lib/UnityRedis.php";
 require_once __DIR__ . "/../resources/lib/UnityGithub.php";
 require_once __DIR__ . "/../resources/lib/exceptions/PhpUnitNoDieException.php";
+require_once __DIR__ . "/../resources/lib/exceptions/UnitySQLRecordNotFound.php";
 
 $GLOBALS["PHPUNIT_NO_DIE_PLEASE"] = true;