catch redirect exception is now in http_post

Author: simonLeary42

test/functional/NewUserTest.php

@@ -14,44 +14,26 @@ private function assertNumberGroupRequests(int $x)
 
     private function requestGroupCreation()
     {
-        $redirectedOrDied = false;
-        try {
-            http_post(
-                __DIR__ . "/../../webroot/panel/new_account.php",
-                ["new_user_sel" => "pi", "eula" => "agree", "confirm_pi" => "agree"]
-            );
-        } catch (\UnityWebPortal\lib\exceptions\PhpUnitNoDieException) {
-            $redirectedOrDied = true;
-        }
-        $this->assertTrue($redirectedOrDied);
+        http_post(
+            __DIR__ . "/../../webroot/panel/new_account.php",
+            ["new_user_sel" => "pi", "eula" => "agree", "confirm_pi" => "agree"]
+        );
     }
 
     private function requestGroupMembership(string $gid)
     {
-        $redirectedOrDied = false;
-        try {
-            http_post(
-                __DIR__ . "/../../webroot/panel/new_account.php",
-                ["new_user_sel" => "not_pi", "eula" => "agree", "pi" => $gid]
-            );
-        } catch (\UnityWebPortal\lib\exceptions\PhpUnitNoDieException) {
-            $redirectedOrDied = true;
-        }
-        $this->assertTrue($redirectedOrDied);
+        http_post(
+            __DIR__ . "/../../webroot/panel/new_account.php",
+            ["new_user_sel" => "not_pi", "eula" => "agree", "pi" => $gid]
+        );
     }
 
     private function cancelAllRequests()
     {
-        $redirectedOrDied = false;
-        try {
-            http_post(
-                __DIR__ . "/../../webroot/panel/new_account.php",
-                ["cancel" => "true"] // value of cancel is arbitrary
-            );
-        } catch (\UnityWebPortal\lib\exceptions\PhpUnitNoDieException) {
-            $redirectedOrDied = true;
-        }
-        $this->assertTrue($redirectedOrDied);
+        http_post(
+            __DIR__ . "/../../webroot/panel/new_account.php",
+            ["cancel" => "true"] // value of cancel is arbitrary
+        );
     }
 
     // delete requests made by that user