add tests for removing group members

Author: simonLeary42

test/functional/PiRemoveUserTest.php

@@ -0,0 +1,66 @@
+<?php
+
+use PHPUnit\Framework\TestCase;
+use PHPUnit\Framework\Attributes\DataProvider;
+use UnityWebPortal\lib\UnityUser;
+
+class PiRemoveUserTest extends TestCase {
+    private function removeUser(string $uid)
+    {
+        post(
+            __DIR__ . "/../../webroot/panel/pi.php",
+            ["form_name" => "remUser", "uid" => $uid]
+        );
+    }
+
+    public function testRemoveUser()
+    {
+        global $USER, $LDAP, $SQL, $MAILER, $REDIS, $WEBHOOK;
+        switchUser(...getUserIsPIHasAtLeastOneMember());
+        $pi = $USER;
+        $piUid = $USER->getUID();
+        $piGroup = $USER->getPIGroup();
+        $this->assertTrue($piGroup->exists());
+        $memberUIDs = $piGroup->getGroupMemberUIDs();
+        // the 0th member of the PI group is the PI
+        $this->assertGreaterThan(1, count($memberUIDs));
+        $memberToDelete = null;
+        foreach ($memberUIDs as $uid) {
+            if ($uid != $piUid) {
+                $memberToDelete = new UnityUser($uid, $LDAP, $SQL, $MAILER, $REDIS, $WEBHOOK);
+                break;
+            }
+        }
+        $this->assertNotEquals($pi->getUID(), $memberToDelete->getUID());
+        $this->assertTrue($piGroup->userExists($memberToDelete));
+        try {
+            $this->removeUser($memberToDelete->getUID());
+            $this->assertFalse($piGroup->userExists($memberToDelete));
+        } finally {
+            if (!$piGroup->userExists($memberToDelete)) {
+                $piGroup->newUserRequest($memberToDelete);
+                $piGroup->approveUser($memberToDelete);
+            }
+        }
+    }
+
+    public function testRemovePIFromTheirOwnGroup()
+    {
+        global $USER, $LDAP, $SQL, $MAILER, $REDIS, $WEBHOOK;
+        switchUser(...getUserIsPIHasAtLeastOneMember());
+        $pi = $USER;
+        $piGroup = $USER->getPIGroup();
+        $this->assertTrue($piGroup->exists());
+        $this->assertTrue($piGroup->userExists($pi));
+        $this->expectException(Exception::class);
+        try {
+            $this->removeUser($pi->getUID());
+            $this->assertTrue($piGroup->userExists($pi));
+        } finally {
+            if (!$piGroup->userExists($pi)) {
+                $piGroup->newUserRequest($pi);
+                $piGroup->approveUser($pi);
+            }
+       }
+    }
+}

test/phpunit-bootstrap.php

@@ -67,7 +67,10 @@ function post(string $phpfile, array $post_data): void
         include $phpfile;
         ob_get_clean(); // discard output
     } catch (Throwable $e) {
-        error_log(ob_get_clean()); // don't discard output
+        $output = ob_get_clean();
+        if (!empty($output)) {
+            error_log($output);
+        }
         throw $e;
     } finally {
         unset($_POST);
@@ -119,3 +122,8 @@ function getUserIsPIHasNoMembersNoMemberRequests()
 {
     return ["[email protected]", "foo", "bar", "[email protected]"];
 }
+
+function getUserIsPIHasAtLeastOneMember()
+{
+    return ["[email protected]", "foo", "bar", "[email protected]"];
+}