Skip to content

Refactor filter and laterality modules: joblib is not optional #227

Open
@jhlegarreta

Description

@jhlegarreta

The filter and laterality modules try to use joblib modules conditionally if importing it is successful:

joblib, have_joblib, _ = optional_package("joblib")

joblib, have_joblib, _ = optional_package("joblib")

However, joblib is a required dependency:,

so the if/else blocks in the above modules are not necessary, e.g. (there are multiple hits):

if have_joblib and n_jobs > 0:

if (have_joblib & (self.parallel_jobs > 1)):

Removing the conditional blocks may require some work, as the else blocks seem to contain a more complex/different logic with respect to the counterpart using the parallelization capabilities.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions