Write the tests for StandingsRepo and fix its bugs. Change the way of sorting items in positions map creators.

Author: SiekamCebule

lib/models/db/event_series/standings/standings_positions_map_creator/standings_positions_with_ex_aequos_creator.dart

@@ -13,7 +13,11 @@ class StandingsPositionsWithExAequosCreator<T extends StandingsRecord>
   }
 
   void _sortRecords() {
-    _records.sort((a, b) => b.compareTo(a));
+    _records.sort((a, b) {
+      if (a.score > b.score) return -1;
+      if (a.score < b.score) return 1;
+      return 0; // Maintain original order if scores are equal
+    });
   }
 
   Map<int, List<T>> _generatePositionsMap() {

lib/models/db/event_series/standings/standings_repo.dart

@@ -8,7 +8,7 @@ class StandingsRepo<E, S extends Score, R extends StandingsRecord<E, S>>
     implements ValueRepo<Map<int, List<R>>> {
   StandingsRepo({required this.positionsCreator, List<R>? initialRecords}) {
     if (initialRecords != null) {
-      _records = initialRecords;
+      _records = List.of(initialRecords);
       _updateStandings();
       set(_standings);
     }
@@ -28,12 +28,18 @@ class StandingsRepo<E, S extends Score, R extends StandingsRecord<E, S>>
       }
     }
 
-    if (recordToChange != null) {
-      throw StateError('Standings does not have the entiy (${newRecord.entity})');
+    if (recordToChange == null) {
+      _records.add(newRecord);
+    } else {
+      _records[_records.indexOf(recordToChange)] = newRecord;
     }
 
-    _records[_records.indexOf(recordToChange!)] = newRecord;
+    _updateStandings();
+    set(_standings);
+  }
 
+  void remove({required R record}) {
+    _records.remove(record);
     _updateStandings();
     set(_standings);
   }
@@ -42,6 +48,10 @@ class StandingsRepo<E, S extends Score, R extends StandingsRecord<E, S>>
     _standings = positionsCreator.create(_records);
   }
 
+  List<R> get leaders {
+    return atPosition(1);
+  }
+
   List<R> atPosition(int position) {
     if (!_standings.containsKey(position)) {
       throw StateError('Standings does not have any entity at $position position');
@@ -50,28 +60,40 @@ class StandingsRepo<E, S extends Score, R extends StandingsRecord<E, S>>
   }
 
   int positionOf(E entity) {
-    int? toReturn;
-    _standings.forEach((position, entities) {
-      if (entities.contains(entity)) {
-        toReturn = position;
+    for (var entry in _standings.entries) {
+      bool hasRecordWithEntity =
+          entry.value.where((record) => record.entity == entity).length == 1;
+      if (hasRecordWithEntity) {
+        return entry.key;
       }
-    });
-    if (toReturn == null) {
-      throw StateError('The entity ($entity) is not contained by standings');
     }
-    return toReturn!;
+    throw _notContainEntityError(entity);
   }
 
-  S? scoreOf(E entity) {
+  S scoreOf(E entity) {
     for (var record in _records) {
       if (record.entity == entity) {
         return record.score;
       }
     }
-    return null;
+    throw _notContainEntityError(entity);
   }
 
-  int get length => last.length;
+  Error _notContainEntityError(E entity) {
+    return StateError('The entity ($entity) is not contained by standings');
+  }
+
+  int get length => _records.length;
+
+  int get lastPosition {
+    return _standings.keys.reduce((first, second) {
+      if (second > first) {
+        return second;
+      } else {
+        return first;
+      }
+    });
+  }
 
   bool containsEntity(E entity) {
     return _records.where((record) => record.entity == entity).isNotEmpty;

test/standings/standings_repo_test.dart

@@ -0,0 +1,111 @@
+import 'package:flutter_test/flutter_test.dart';
+import 'package:sj_manager/models/db/event_series/standings/score/basic_score_types.dart';
+import 'package:sj_manager/models/db/event_series/standings/standings_positions_map_creator/standings_positions_with_ex_aequos_creator.dart';
+import 'package:sj_manager/models/db/event_series/standings/standings_record.dart';
+import 'package:sj_manager/models/db/event_series/standings/standings_repo.dart';
+
+void main() {
+  group(StandingsRepo, () {
+    late StandingsRepo<String, PointsScore, StandingsRecord<String, PointsScore>> repo;
+
+    test('Adding, editing and removing; updating standings', () {
+      const stoch = StandingsRecord(entity: 'Kamil Stoch', score: PointsScore(315.5));
+      const kubacki = StandingsRecord(entity: 'Dawid Kubacki', score: PointsScore(333.4));
+      const zyla = StandingsRecord(entity: 'Piotr Żyła', score: PointsScore(315.5));
+      const geiger = StandingsRecord(entity: 'Karl Geiger', score: PointsScore(330.0));
+      const eisenbichler =
+          StandingsRecord(entity: 'Markus Eisenbichler', score: PointsScore(350.1));
+
+      repo = StandingsRepo(
+        positionsCreator: StandingsPositionsWithExAequosCreator(),
+        initialRecords: const [stoch, kubacki, zyla],
+      );
+
+      repo.update(newRecord: geiger);
+      repo.update(newRecord: eisenbichler);
+      expect(repo.leaders.single, eisenbichler);
+      expect(repo.last.values.last, [stoch, zyla]); // Records at last position
+      expect(repo.length, 5);
+      repo.remove(record: eisenbichler);
+      expect(repo.leaders.single, kubacki);
+      expect(repo.length, 4);
+      expect(repo.containsEntity('Markus Eisenbichler'), false);
+      repo.update(newRecord: stoch.copyWith(score: const PointsScore(441.4)));
+      expect(repo.leaders.single.entity, 'Kamil Stoch');
+      expect(repo.length, 4);
+
+      repo.dispose();
+    });
+
+    group('Repo view utilities', () {
+      const kot = StandingsRecord(entity: 'Maciej Kot', score: PointsScore(116.4));
+      const hula = StandingsRecord(entity: 'Stefan Hula', score: PointsScore(116.4));
+      const kobayashi =
+          StandingsRecord(entity: 'Ryoyu Kobayashi', score: PointsScore(137.8));
+      const danielHuber =
+          StandingsRecord(entity: 'Daniel Huber', score: PointsScore(137.8));
+      const stefanHuber =
+          StandingsRecord(entity: 'Stefan Huber', score: PointsScore(120.1));
+      const wohlgenannt =
+          StandingsRecord(entity: 'Ulrich Wohlgenannt', score: PointsScore(111.5));
+      const kos = StandingsRecord(entity: 'Lovro Kos', score: PointsScore(127.5));
+      const prevc = StandingsRecord(entity: 'Domen Prevc', score: PointsScore(114.9));
+      const peier = StandingsRecord(entity: 'Killian Peier', score: PointsScore(110.8));
+
+      setUpAll(() {
+        repo = StandingsRepo(
+          positionsCreator: StandingsPositionsWithExAequosCreator(),
+          initialRecords: const [
+            kot,
+            hula,
+            kobayashi,
+            danielHuber,
+            stefanHuber,
+            wohlgenannt,
+            kos,
+            prevc,
+            peier,
+          ],
+        );
+      });
+
+      test('leaders', () {
+        expect(repo.leaders, [kobayashi, danielHuber]);
+        expect(() => repo.leaders.single, throwsA(isA<StateError>()));
+      });
+
+      test('records by position', () {
+        expect(repo.leaders, repo.atPosition(1));
+        expect(repo.atPosition(4), [stefanHuber]);
+        expect(() => repo.atPosition(0), throwsA(isA<StateError>()));
+        expect(() => repo.atPosition(18), throwsA(isA<StateError>()));
+      });
+
+      test('position by entity', () {
+        expect(repo.positionOf('Ulrich Wohlgenannt'), 8);
+        expect(repo.positionOf('Stefan Huber'), 4);
+        expect(() => repo.positionOf('Karol Wojtyła'), throwsA(isA<StateError>()));
+      });
+
+      test('score by entity', () {
+        expect(repo.scoreOf('Domen Prevc'), const PointsScore(114.9));
+        expect(repo.scoreOf('Daniel Huber'), const PointsScore(137.8));
+        expect(() => repo.scoreOf('Peter Prevc'), throwsA(isA<StateError>()));
+      });
+
+      test('length', () {
+        expect(repo.length, 9);
+      });
+
+      test('whether contains an entity', () {
+        expect(repo.containsEntity('Stefan Hula'), true);
+        expect(repo.containsEntity('Stefan Huber'), true);
+        expect(repo.containsEntity('Junshiro Kobayashi'), false);
+      });
+
+      tearDownAll(() {
+        repo.dispose();
+      });
+    });
+  });
+}