Skip to content

Makefile does not properly depend on .clippy.toml #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tamird opened this issue Mar 25, 2025 · 3 comments
Open

Makefile does not properly depend on .clippy.toml #1151

tamird opened this issue Mar 25, 2025 · 3 comments
Labels
• kbuild Related to building the kernel, `make`, `Kbuild`, `Kconfig` options...

Comments

@tamird
Copy link

tamird commented Mar 25, 2025

Changing the content of .clippy.toml does not provoke make CLIPPY=1 all to re-invoke clippy.

/cc @ojeda
@ojeda
Copy link
Member

ojeda commented Mar 25, 2025 •
edited
Loading

Yeah, I noticed it too (when I was adding doc-valid-idents for the cleanup series), it is on my TODO list. Thanks!

@ojeda ojeda added the • kbuild Related to building the kernel, `make`, `Kbuild`, `Kconfig` options... label Mar 25, 2025
@ojeda
Copy link
Member

ojeda commented May 20, 2025

Lore: https://lore.kernel.org/rust-for-linux/[email protected]/

intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue May 20, 2025
@ojeda @intel-lab-lkp
rust: kbuild: rebuild if .clippy.toml changes
8a1bc8f 
We rarely modify `.clippy.toml`, but currently we do not rebuild if that
happens, thus it is easy to miss possible changes in lints.

Thus rebuild in case of changes.

Cc: [email protected]
Reported-by: Tamir Duberstein <[email protected]>
Closes: Rust-for-Linux#1151
Fixes: 7d56786 ("rust: introduce `.clippy.toml`")
Signed-off-by: Miguel Ojeda <[email protected]>
@ojeda
Copy link
Member

ojeda commented May 20, 2025

v2: https://lore.kernel.org/rust-for-linux/[email protected]/

intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue May 20, 2025
@ojeda @intel-lab-lkp
rust: kbuild: rebuild if .clippy.toml changes
67c4101 
We rarely modify `.clippy.toml`, but currently we do not rebuild if that
happens, thus it is easy to miss possible changes in lints.

Thus rebuild in case of changes.

Cc: [email protected]
Reported-by: Tamir Duberstein <[email protected]>
Closes: Rust-for-Linux#1151
Fixes: 7d56786 ("rust: introduce `.clippy.toml`")
Signed-off-by: Miguel Ojeda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
• kbuild Related to building the kernel, `make`, `Kbuild`, `Kconfig` options...
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ojeda @tamird