Skip to content

libra_py.tsh is deprecated but still imported in step3.py #180

Open
@Wholinator

Description

@Wholinator

Hello, apologies if I'm doing anything wrong here.

But I've noticed that on brand new installations of Libra, when attempting to run a python script that calls functions within the libra_py.workflows.nbra.step3 file, that step3.py file has an import here which attempts to import a libra_py.tsh file. This file does not exist in this location. If I look inside libra_py folder I can see there is a tsh_stat.py file but no tsh.py file.

Having searched the repository for the function that step3.py wants to call from tsh.py file, I find that a tsh.py file does actually exist within the repository and contain the code that looks right to me but this tsh.py file exists inside a folder called "deprecated_code/python". Copying this file verbatim in to the location that step3.py expects it to exist in fixes this import error.

To be more specific, the exact command run inside the libra root directory is
cp deprecated_code/python/tsh.py _build/src/libra_py/

I haven't been able to track down whether these functions are actually being called. Should the tsh.py file really be deprecated? Or should the functions that utilize it also be deprecated? Either way, step3 and any other files which expect tsh.py in libra_py will not function currently.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions