fix: missed validation of subscriptionManager in reconnection logic (#34)

Romazes · web-flow · commit 78acb5d2f055 · 2025-05-02T19:57:54.000-03:00
diff --git a/QuantConnect.AlpacaBrokerage/AlpacaBrokerage.cs b/QuantConnect.AlpacaBrokerage/AlpacaBrokerage.cs
@@ -1,4 +1,4 @@
-﻿/*
+/*
  * QUANTCONNECT.COM - Democratizing Finance, Empowering Individuals.
  * Lean Algorithmic Trading Engine v2.0. Copyright 2014 QuantConnect Corporation.
  *
@@ -654,10 +654,14 @@ private void RunReconnectionLogic(int secondsDelay)
                 }
                 else
                 {
-                    // resubscribe
-                    var symbols = _subscriptionManager.GetSubscribedSymbols();
-                    Unsubscribe(symbols);
-                    Subscribe(symbols);
+                    // if we are used as a brokerage ignore data queue handler updates
+                    if (_subscriptionManager != null)
+                    {
+                        // resubscribe
+                        var symbols = _subscriptionManager.GetSubscribedSymbols();
+                        Unsubscribe(symbols);
+                        Subscribe(symbols);
+                    }
                     // let consumers know we are reconnected, avoid lean killing us
                     OnMessage(new BrokerageMessageEvent(BrokerageMessageType.Reconnect, "Reconnected", "Brokerage Reconnected"));
                 }

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-/*`
	`1`	`+/*`
`2`	`2`	`* QUANTCONNECT.COM - Democratizing Finance, Empowering Individuals.`
`3`	`3`	`* Lean Algorithmic Trading Engine v2.0. Copyright 2014 QuantConnect Corporation.`
`4`	`4`	`*`
`@@ -654,10 +654,14 @@ private void RunReconnectionLogic(int secondsDelay)`
`654`	`654`	`}`
`655`	`655`	`else`
`656`	`656`	`{`
`657`		`- // resubscribe`
`658`		`- var symbols = _subscriptionManager.GetSubscribedSymbols();`
`659`		`- Unsubscribe(symbols);`
`660`		`- Subscribe(symbols);`
	`657`	`+ // if we are used as a brokerage ignore data queue handler updates`
	`658`	`+ if (_subscriptionManager != null)`
	`659`	`+ {`
	`660`	`+ // resubscribe`
	`661`	`+ var symbols = _subscriptionManager.GetSubscribedSymbols();`
	`662`	`+ Unsubscribe(symbols);`
	`663`	`+ Subscribe(symbols);`
	`664`	`+ }`
`661`	`665`	`// let consumers know we are reconnected, avoid lean killing us`
`662`	`666`	`OnMessage(new BrokerageMessageEvent(BrokerageMessageType.Reconnect, "Reconnected", "Brokerage Reconnected"));`
`663`	`667`	`}`